chore(release): 0.8.2

2025-11-14 01:38:56 +00:00
5 changed files with 39 additions and 95 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,15 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

 ## [Unreleased]

-## [0.10.0] - 2025-11-15
+## [0.8.2] - 2025-11-14

 ### Added
- implement take errors
-
-## [0.9.0] - 2025-11-15
-
-### Added
- mad not properly surfaces panics
 - add publish
 - add readme

--- a/Cargo.lock
+++ b/Cargo.lock
@@ -222,7 +222,7 @@ dependencies = [

 [[package]]
 name = "notmad"
-version = "0.10.0"
+version = "0.8.1"
 dependencies = [
 "anyhow",
 "async-trait",
@@ -243,7 +243,7 @@ version = "0.50.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "7957b9740744892f114936ab4a57b3f487491bbeafaf8083688b16841a4240e5"
 dependencies = [
- "windows-sys 0.60.2",
+ "windows-sys 0.61.2",
 ]

 [[package]]
@@ -503,9 +503,9 @@ dependencies = [

 [[package]]
 name = "tracing"
-version = "0.1.43"
+version = "0.1.41"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2d15d90a0b5c19378952d479dc858407149d7bb45a14de0142f6c534b16fc647"
+checksum = "784e0ac535deb450455cbfa28a6f0df145ea1bb7ae51b821cf5e7927fdcfbdd0"
 dependencies = [
 "log",
 "pin-project-lite",
@@ -515,9 +515,9 @@ dependencies = [

 [[package]]
 name = "tracing-attributes"
-version = "0.1.31"
+version = "0.1.28"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7490cfa5ec963746568740651ac6781f701c9c5ea257c58e057f3ba8cf69e8da"
+checksum = "395ae124c09f9e6918a2310af6038fba074bcf474ac352496d5910dd59a2226d"
 dependencies = [
 "proc-macro2",
 "quote",
@@ -526,9 +526,9 @@ dependencies = [

 [[package]]
 name = "tracing-core"
-version = "0.1.35"
+version = "0.1.33"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "7a04e24fab5c89c6a36eb8558c9656f30d81de51dfa4d3b45f26b21d61fa0a6c"
+checksum = "e672c95779cf947c5311f83787af4fa8fffd12fb27e4993211a84bdfd9610f9c"
 dependencies = [
 "once_cell",
 "valuable",
@@ -547,9 +547,9 @@ dependencies = [

 [[package]]
 name = "tracing-subscriber"
-version = "0.3.22"
+version = "0.3.20"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "2f30143827ddab0d256fd843b7a66d164e9f271cfa0dde49142c5ca0ca291f1e"
+checksum = "2054a14f5307d601f88daf0553e1cbf472acc4f2c51afab632431cdcd72124d5"
 dependencies = [
 "matchers",
 "nu-ansi-term",
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -3,7 +3,7 @@ members = ["crates/*"]
 resolver = "2"

 [workspace.package]
-version = "0.10.0"
+version = "0.8.2"

 [workspace.dependencies]
 mad = { path = "crates/mad" }
--- a/crates/mad/src/lib.rs
+++ b/crates/mad/src/lib.rs
@@ -77,11 +77,8 @@

 use futures::stream::FuturesUnordered;
 use futures_util::StreamExt;
-use std::{error::Error, fmt::Display, sync::Arc};
-use tokio::{
-    signal::unix::{SignalKind, signal},
-    task::JoinError,
-};
+use std::{fmt::Display, sync::Arc, error::Error};
+use tokio::signal::unix::{SignalKind, signal};

 use tokio_util::sync::CancellationToken;

@@ -104,13 +101,15 @@ pub enum MadError {

    /// Error that occurred during the run phase of a component.
    #[error(transparent)]
-    RunError { run: anyhow::Error },
+    RunError { 
+        run: anyhow::Error 
+    },

    /// Error that occurred during the close phase of a component.
    #[error("component(s) failed during close")]
-    CloseError {
+    CloseError { 
        #[source]
-        close: anyhow::Error,
+        close: anyhow::Error 
    },

    /// Multiple errors from different components.
@@ -166,10 +165,6 @@ impl AggregateError {
    pub fn get_errors(&self) -> &[MadError] {
        &self.errors
    }
-
-    pub fn take_errors(self) -> Vec<MadError> {
-        self.errors
-    }
 }

 impl Display for AggregateError {
@@ -185,7 +180,7 @@ impl Display for AggregateError {
        writeln!(f, "{} component errors occurred:", self.errors.len())?;
        for (i, error) in self.errors.iter().enumerate() {
            write!(f, "\n[Component {}] {}", i + 1, error)?;
-
+            
            // Print the error chain for each component error
            let mut source = error.source();
            let mut level = 1;
@@ -506,32 +501,11 @@ impl Mad {

                tracing::debug!(component = name, "mad running");

-                let handle = tokio::spawn(async move { comp.run(job_cancellation).await });
-
                tokio::select! {
                    _ = cancellation_token.cancelled() => {
                        error_tx.send(CompletionResult { res: Ok(()) , name  }).await
                    }
-                    res = handle => {
-                     let res = match res {
-                         Ok(res) => res,
-                         Err(join) => {
-                             match join.source() {
-                                 Some(error) => {
-                                     Err(MadError::RunError{run: anyhow::anyhow!("component aborted: {:?}", error)})
-                                 },
-                                 None => {
-                                     if join.is_panic(){
-                                         Err(MadError::RunError { run: anyhow::anyhow!("component panicked: {}", join) })
-                                     } else {
-                                         Err(MadError::RunError { run: anyhow::anyhow!("component faced unknown error: {}", join) })
-                                     }
-                                 },
-                             }
-                         },
-                     };
-
-
+                    res = comp.run(job_cancellation) => {
                        error_tx.send(CompletionResult { res , name  }).await
                    }
                }
@@ -822,13 +796,13 @@ mod tests {
            .context("failed to read configuration")
            .context("unable to initialize database")
            .context("service startup failed");
-
+        
        let mad_error = MadError::Inner(error);
        let display = format!("{}", mad_error);
-
+        
        // Should display the top-level error message
        assert!(display.contains("service startup failed"));
-
+        
        // Test error chain iteration
        if let MadError::Inner(ref e) = mad_error {
            let chain: Vec<String> = e.chain().map(|c| c.to_string()).collect();
@@ -844,26 +818,26 @@ mod tests {
    fn test_aggregate_error_display() {
        let error1 = MadError::Inner(
            anyhow::anyhow!("database connection failed")
-                .context("failed to connect to PostgreSQL"),
+                .context("failed to connect to PostgreSQL")
        );
-
+        
        let error2 = MadError::Inner(
            anyhow::anyhow!("port already in use")
                .context("failed to bind to port 8080")
-                .context("web server initialization failed"),
+                .context("web server initialization failed")
        );
-
+        
        let aggregate = MadError::AggregateError(AggregateError {
            errors: vec![error1, error2],
        });
-
+        
        let display = format!("{}", aggregate);
-
+        
        // Check that it shows multiple errors
        assert!(display.contains("2 component errors occurred"));
        assert!(display.contains("[Component 1]"));
        assert!(display.contains("[Component 2]"));
-
+        
        // Check that context chains are displayed
        assert!(display.contains("failed to connect to PostgreSQL"));
        assert!(display.contains("database connection failed"));
@@ -878,7 +852,7 @@ mod tests {
        let aggregate = AggregateError {
            errors: vec![error],
        };
-
+        
        let display = format!("{}", aggregate);
        // Single error should be displayed directly
        assert!(display.contains("single error"));
@@ -890,9 +864,9 @@ mod tests {
        let error = MadError::Inner(
            anyhow::anyhow!("root cause")
                .context("middle layer")
-                .context("top layer"),
+                .context("top layer")
        );
-
+        
        // Test that we can access the error chain
        if let MadError::Inner(ref e) = error {
            let chain: Vec<String> = e.chain().map(|c| c.to_string()).collect();
@@ -908,13 +882,13 @@ mod tests {
    #[tokio::test]
    async fn test_component_error_propagation() {
        struct FailingComponent;
-
+        
        #[async_trait::async_trait]
        impl Component for FailingComponent {
            fn name(&self) -> Option<String> {
                Some("test-component".to_string())
            }
-
+            
            async fn run(&self, _cancel: CancellationToken) -> Result<(), MadError> {
                Err(anyhow::anyhow!("IO error")
                    .context("failed to open file")
@@ -922,16 +896,16 @@ mod tests {
                    .into())
            }
        }
-
+        
        let result = Mad::builder()
            .add(FailingComponent)
            .cancellation(Some(std::time::Duration::from_millis(100)))
            .run()
            .await;
-
+        
        assert!(result.is_err());
        let error = result.unwrap_err();
-
+        
        // Check error display
        let display = format!("{}", error);
        assert!(display.contains("component initialization failed"));
--- a/crates/mad/tests/mod.rs
+++ b/crates/mad/tests/mod.rs
@@ -138,30 +138,6 @@ async fn test_can_shutdown_gracefully() -> anyhow::Result<()> {
    Ok(())
 }

-#[tokio::test]
-#[traced_test]
-async fn test_component_panics_shutdowns_cleanly() -> anyhow::Result<()> {
-    let res = Mad::builder()
-        .add_fn({
-            move |_cancel| async move {
-                panic!("my inner panic");
-            }
-        })
-        .add_fn(|cancel| async move {
-            cancel.cancelled().await;
-
-            Ok(())
-        })
-        .run()
-        .await;
-
-    let err_content = res.unwrap_err().to_string();
-    assert!(err_content.contains("component panicked"));
-    assert!(err_content.contains("my inner panic"));
-
-    Ok(())
-}
-
 #[test]
 fn test_can_easily_transform_error() -> anyhow::Result<()> {
    fn fallible() -> anyhow::Result<()> {