chore(release): v0.10.0 (#40 )

chore(release): 0.10.0 Co-authored-by: cuddle-please <bot@cuddle.sh> Reviewed-on: #40
feat: implement take errors
2025-11-15 14:48:14 +01:00 · 2025-11-15 14:47:24 +01:00 · 2025-11-15 14:35:36 +01:00 · 2025-11-15 14:33:00 +01:00 · 2025-11-14 02:38:11 +01:00 · 2025-11-13 03:15:23 +01:00
5 changed files with 107 additions and 95 deletions
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -6,6 +6,24 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

 ## [Unreleased]

+## [0.10.0] - 2025-11-15
+
+### Added
+- implement take errors
+
+## [0.9.0] - 2025-11-15
+
+### Added
+- mad not properly surfaces panics
+- add publish
+- add readme
+
+### Fixed
+- *(deps)* update all dependencies (#38)
+
+### Other
+- *(deps)* update rust crate tracing-subscriber to v0.3.20 (#37)
+
 ## [0.8.1] - 2025-08-09

 ### Other
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -195,11 +195,11 @@ checksum = "a7a70ba024b9dc04c27ea2f0c0548feb474ec5c54bba33a7f72f873a39d07b24"

 [[package]]
 name = "matchers"
-version = "0.1.0"
+version = "0.2.0"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8263075bb86c5a1b1427b5ae862e8889656f126e9f77c484496e8b47cf5c5558"
+checksum = "d1525a2a28c7f4fa0fc98bb91ae755d1e2d1505079e05539e35bc876b5d65ae9"
 dependencies = [
- "regex-automata 0.1.10",
+ "regex-automata",
 ]

 [[package]]
@@ -222,7 +222,7 @@ dependencies = [

 [[package]]
 name = "notmad"
-version = "0.8.1"
+version = "0.9.0"
 dependencies = [
 "anyhow",
 "async-trait",
@@ -239,12 +239,11 @@ dependencies = [

 [[package]]
 name = "nu-ansi-term"
-version = "0.46.0"
+version = "0.50.3"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "77a8165726e8236064dbb45459242600304b42a5ea24ee2948e18e023bf7ba84"
+checksum = "7957b9740744892f114936ab4a57b3f487491bbeafaf8083688b16841a4240e5"
 dependencies = [
- "overload",
- "winapi",
+ "windows-sys 0.61.2",
 ]

 [[package]]
@@ -253,12 +252,6 @@ version = "1.20.2"
 source = "registry+https://github.com/rust-lang/crates.io-index"
 checksum = "1261fe7e33c73b354eab43b1273a57c8f967d0391e80353e51f764ac02cf6775"

-[[package]]
-name = "overload"
-version = "0.1.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b15813163c1d831bf4a13c3610c05c0d03b39feb07f7e09fa234dac9b15aaf39"
-
 [[package]]
 name = "parking_lot"
 version = "0.12.3"
@@ -360,27 +353,6 @@ dependencies = [
 "bitflags",
 ]

-[[package]]
-name = "regex"
-version = "1.11.1"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b544ef1b4eac5dc2db33ea63606ae9ffcfac26c1416a2806ae0bf5f56b201191"
-dependencies = [
- "aho-corasick",
- "memchr",
- "regex-automata 0.4.9",
- "regex-syntax 0.8.5",
-]
-
-[[package]]
-name = "regex-automata"
-version = "0.1.10"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6c230d73fb8d8c1b9c0b3135c5142a8acee3a0558fb8db5cf1cb65f8d7862132"
-dependencies = [
- "regex-syntax 0.6.29",
-]
-
 [[package]]
 name = "regex-automata"
 version = "0.4.9"
@@ -389,15 +361,9 @@ checksum = "809e8dc61f6de73b46c85f4c96486310fe304c434cfa43669d7b40f711150908"
 dependencies = [
 "aho-corasick",
 "memchr",
- "regex-syntax 0.8.5",
+ "regex-syntax",
 ]

-[[package]]
-name = "regex-syntax"
-version = "0.6.29"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f162c6dd7b008981e4d40210aca20b4bd0f9b60ca9271061b07f78537722f2e1"
-
 [[package]]
 name = "regex-syntax"
 version = "0.8.5"
@@ -581,14 +547,14 @@ dependencies = [

 [[package]]
 name = "tracing-subscriber"
-version = "0.3.19"
+version = "0.3.20"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "e8189decb5ac0fa7bc8b96b7cb9b2701d60d48805aca84a238004d665fcc4008"
+checksum = "2054a14f5307d601f88daf0553e1cbf472acc4f2c51afab632431cdcd72124d5"
 dependencies = [
 "matchers",
 "nu-ansi-term",
 "once_cell",
- "regex",
+ "regex-automata",
 "sharded-slab",
 "smallvec",
 "thread_local",
@@ -645,28 +611,6 @@ dependencies = [
 "wit-bindgen-rt",
 ]

-[[package]]
-name = "winapi"
-version = "0.3.9"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "5c839a674fcd7a98952e593242ea400abe93992746761e38641405d28b00f419"
-dependencies = [
- "winapi-i686-pc-windows-gnu",
- "winapi-x86_64-pc-windows-gnu",
-]
-
-[[package]]
-name = "winapi-i686-pc-windows-gnu"
-version = "0.4.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ac3b87c63620426dd9b991e5ce0329eff545bccbbb34f3be09ff6fb6ab51b7b6"
-
-[[package]]
-name = "winapi-x86_64-pc-windows-gnu"
-version = "0.4.0"
-source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "712e227841d057c1ee1cd2fb22fa7e5a5461ae8e48fa2ca79ec42cfc1931183f"
-
 [[package]]
 name = "windows-link"
 version = "0.2.1"
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -3,7 +3,7 @@ members = ["crates/*"]
 resolver = "2"

 [workspace.package]
-version = "0.8.1"
+version = "0.10.0"

 [workspace.dependencies]
 mad = { path = "crates/mad" }
--- a/crates/mad/src/lib.rs
+++ b/crates/mad/src/lib.rs
@@ -77,8 +77,11 @@

 use futures::stream::FuturesUnordered;
 use futures_util::StreamExt;
-use std::{fmt::Display, sync::Arc, error::Error};
-use tokio::signal::unix::{SignalKind, signal};
+use std::{error::Error, fmt::Display, sync::Arc};
+use tokio::{
+    signal::unix::{SignalKind, signal},
+    task::JoinError,
+};

 use tokio_util::sync::CancellationToken;

@@ -101,15 +104,13 @@ pub enum MadError {

    /// Error that occurred during the run phase of a component.
    #[error(transparent)]
-    RunError { 
-        run: anyhow::Error 
-    },
+    RunError { run: anyhow::Error },

    /// Error that occurred during the close phase of a component.
    #[error("component(s) failed during close")]
-    CloseError { 
+    CloseError {
        #[source]
-        close: anyhow::Error 
+        close: anyhow::Error,
    },

    /// Multiple errors from different components.
@@ -165,6 +166,10 @@ impl AggregateError {
    pub fn get_errors(&self) -> &[MadError] {
        &self.errors
    }
+
+    pub fn take_errors(self) -> Vec<MadError> {
+        self.errors
+    }
 }

 impl Display for AggregateError {
@@ -180,7 +185,7 @@ impl Display for AggregateError {
        writeln!(f, "{} component errors occurred:", self.errors.len())?;
        for (i, error) in self.errors.iter().enumerate() {
            write!(f, "\n[Component {}] {}", i + 1, error)?;
-            
+
            // Print the error chain for each component error
            let mut source = error.source();
            let mut level = 1;
@@ -501,11 +506,32 @@ impl Mad {

                tracing::debug!(component = name, "mad running");

+                let handle = tokio::spawn(async move { comp.run(job_cancellation).await });
+
                tokio::select! {
                    _ = cancellation_token.cancelled() => {
                        error_tx.send(CompletionResult { res: Ok(()) , name  }).await
                    }
-                    res = comp.run(job_cancellation) => {
+                    res = handle => {
+                     let res = match res {
+                         Ok(res) => res,
+                         Err(join) => {
+                             match join.source() {
+                                 Some(error) => {
+                                     Err(MadError::RunError{run: anyhow::anyhow!("component aborted: {:?}", error)})
+                                 },
+                                 None => {
+                                     if join.is_panic(){
+                                         Err(MadError::RunError { run: anyhow::anyhow!("component panicked: {}", join) })
+                                     } else {
+                                         Err(MadError::RunError { run: anyhow::anyhow!("component faced unknown error: {}", join) })
+                                     }
+                                 },
+                             }
+                         },
+                     };
+
+
                        error_tx.send(CompletionResult { res , name  }).await
                    }
                }
@@ -796,13 +822,13 @@ mod tests {
            .context("failed to read configuration")
            .context("unable to initialize database")
            .context("service startup failed");
-        
+
        let mad_error = MadError::Inner(error);
        let display = format!("{}", mad_error);
-        
+
        // Should display the top-level error message
        assert!(display.contains("service startup failed"));
-        
+
        // Test error chain iteration
        if let MadError::Inner(ref e) = mad_error {
            let chain: Vec<String> = e.chain().map(|c| c.to_string()).collect();
@@ -818,26 +844,26 @@ mod tests {
    fn test_aggregate_error_display() {
        let error1 = MadError::Inner(
            anyhow::anyhow!("database connection failed")
-                .context("failed to connect to PostgreSQL")
+                .context("failed to connect to PostgreSQL"),
        );
-        
+
        let error2 = MadError::Inner(
            anyhow::anyhow!("port already in use")
                .context("failed to bind to port 8080")
-                .context("web server initialization failed")
+                .context("web server initialization failed"),
        );
-        
+
        let aggregate = MadError::AggregateError(AggregateError {
            errors: vec![error1, error2],
        });
-        
+
        let display = format!("{}", aggregate);
-        
+
        // Check that it shows multiple errors
        assert!(display.contains("2 component errors occurred"));
        assert!(display.contains("[Component 1]"));
        assert!(display.contains("[Component 2]"));
-        
+
        // Check that context chains are displayed
        assert!(display.contains("failed to connect to PostgreSQL"));
        assert!(display.contains("database connection failed"));
@@ -852,7 +878,7 @@ mod tests {
        let aggregate = AggregateError {
            errors: vec![error],
        };
-        
+
        let display = format!("{}", aggregate);
        // Single error should be displayed directly
        assert!(display.contains("single error"));
@@ -864,9 +890,9 @@ mod tests {
        let error = MadError::Inner(
            anyhow::anyhow!("root cause")
                .context("middle layer")
-                .context("top layer")
+                .context("top layer"),
        );
-        
+
        // Test that we can access the error chain
        if let MadError::Inner(ref e) = error {
            let chain: Vec<String> = e.chain().map(|c| c.to_string()).collect();
@@ -882,13 +908,13 @@ mod tests {
    #[tokio::test]
    async fn test_component_error_propagation() {
        struct FailingComponent;
-        
+
        #[async_trait::async_trait]
        impl Component for FailingComponent {
            fn name(&self) -> Option<String> {
                Some("test-component".to_string())
            }
-            
+
            async fn run(&self, _cancel: CancellationToken) -> Result<(), MadError> {
                Err(anyhow::anyhow!("IO error")
                    .context("failed to open file")
@@ -896,16 +922,16 @@ mod tests {
                    .into())
            }
        }
-        
+
        let result = Mad::builder()
            .add(FailingComponent)
            .cancellation(Some(std::time::Duration::from_millis(100)))
            .run()
            .await;
-        
+
        assert!(result.is_err());
        let error = result.unwrap_err();
-        
+
        // Check error display
        let display = format!("{}", error);
        assert!(display.contains("component initialization failed"));
--- a/crates/mad/tests/mod.rs
+++ b/crates/mad/tests/mod.rs
@@ -138,6 +138,30 @@ async fn test_can_shutdown_gracefully() -> anyhow::Result<()> {
    Ok(())
 }

+#[tokio::test]
+#[traced_test]
+async fn test_component_panics_shutdowns_cleanly() -> anyhow::Result<()> {
+    let res = Mad::builder()
+        .add_fn({
+            move |_cancel| async move {
+                panic!("my inner panic");
+            }
+        })
+        .add_fn(|cancel| async move {
+            cancel.cancelled().await;
+
+            Ok(())
+        })
+        .run()
+        .await;
+
+    let err_content = res.unwrap_err().to_string();
+    assert!(err_content.contains("component panicked"));
+    assert!(err_content.contains("my inner panic"));
+
+    Ok(())
+}
+
 #[test]
 fn test_can_easily_transform_error() -> anyhow::Result<()> {
    fn fallible() -> anyhow::Result<()> {
Author	SHA1	Message	Date
Kasper Juul Hermansen	494ec05874	chore(release): v0.10.0 (#40 ) All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone/tag Build is passing Details chore(release): 0.10.0 Co-authored-by: cuddle-please <bot@cuddle.sh> Reviewed-on: #40	2025-11-15 14:48:14 +01:00
kjuulh	8c0128612f	feat: implement take errors All checks were successful continuous-integration/drone/push Build is passing Details Signed-off-by: kjuulh <contact@kjuulh.io>	2025-11-15 14:47:24 +01:00
Kasper Juul Hermansen	cbe049b6a2	chore(release): v0.9.0 (#36 ) All checks were successful continuous-integration/drone/push Build is passing Details continuous-integration/drone/tag Build is passing Details chore(release): 0.9.0 Co-authored-by: cuddle-please <bot@cuddle.sh> Reviewed-on: #36	2025-11-15 14:35:36 +01:00
kjuulh	2d6b14ad77	feat: mad not properly surfaces panics All checks were successful continuous-integration/drone/pr Build is passing Details continuous-integration/drone/push Build is passing Details Signed-off-by: kjuulh <contact@kjuulh.io>	2025-11-15 14:33:00 +01:00
Kasper Juul Hermansen	f777ec9b1e	fix(deps): update all dependencies (#38 ) All checks were successful continuous-integration/drone/push Build is passing Details	2025-11-14 02:38:11 +01:00
Kasper Juul Hermansen	2415088792	chore(deps): update rust crate tracing-subscriber to v0.3.20 (#37 ) All checks were successful continuous-integration/drone/push Build is passing Details	2025-11-13 03:15:23 +01:00