diff --git a/src/engine.rs b/src/engine.rs index f2fe8824..cb92a5a9 100644 --- a/src/engine.rs +++ b/src/engine.rs @@ -806,7 +806,7 @@ impl Engine { } else { match rhs { // xxx.fn_name(arg_expr_list) - Expr::FunctionCall(fn_name, _, def_val, pos) => { + Expr::FnCall(fn_name, _, def_val, pos) => { let mut args: Vec<_> = once(obj) .chain(idx_val.downcast_mut::().unwrap().iter_mut()) .collect(); @@ -976,7 +976,7 @@ impl Engine { level: usize, ) -> Result<(), Box> { match expr { - Expr::FunctionCall(_, arg_exprs, _, _) => { + Expr::FnCall(_, arg_exprs, _, _) => { let arg_values = arg_exprs .iter() .map(|arg_expr| self.eval_expr(scope, state, fn_lib, arg_expr, level)) @@ -1233,7 +1233,7 @@ impl Engine { .collect::, _>>()?, )))), - Expr::FunctionCall(fn_name, arg_exprs, def_val, pos) => { + Expr::FnCall(fn_name, arg_exprs, def_val, pos) => { let mut arg_values = arg_exprs .iter() .map(|expr| self.eval_expr(scope, state, fn_lib, expr, level)) @@ -1242,7 +1242,7 @@ impl Engine { let mut args: Vec<_> = arg_values.iter_mut().collect(); // eval - only in function call style - if fn_name == KEYWORD_EVAL + if fn_name.as_ref() == KEYWORD_EVAL && args.len() == 1 && !self.has_override(fn_lib, KEYWORD_EVAL) { @@ -1409,7 +1409,8 @@ impl Engine { .and_then(|pkg| pkg.type_iterators.get(&tid)) }) { // Add the loop variable - scope.push(name.clone(), ()); + let var_name = name.as_ref().clone(); + scope.push(var_name, ()); let index = scope.len() - 1; for a in iter_fn(arr) { @@ -1466,13 +1467,15 @@ impl Engine { Stmt::Let(name, Some(expr), _) => { let val = self.eval_expr(scope, state, fn_lib, expr, level)?; // TODO - avoid copying variable name in inner block? - scope.push_dynamic_value(name.clone(), ScopeEntryType::Normal, val, false); + let var_name = name.as_ref().clone(); + scope.push_dynamic_value(var_name, ScopeEntryType::Normal, val, false); Ok(Default::default()) } Stmt::Let(name, None, _) => { // TODO - avoid copying variable name in inner block? - scope.push(name.clone(), ()); + let var_name = name.as_ref().clone(); + scope.push(var_name, ()); Ok(Default::default()) } @@ -1480,7 +1483,8 @@ impl Engine { Stmt::Const(name, expr, _) if expr.is_constant() => { let val = self.eval_expr(scope, state, fn_lib, expr, level)?; // TODO - avoid copying variable name in inner block? - scope.push_dynamic_value(name.clone(), ScopeEntryType::Constant, val, true); + let var_name = name.as_ref().clone(); + scope.push_dynamic_value(var_name, ScopeEntryType::Constant, val, true); Ok(Default::default()) } diff --git a/src/optimize.rs b/src/optimize.rs index a63075a3..2a8fab4c 100644 --- a/src/optimize.rs +++ b/src/optimize.rs @@ -558,18 +558,18 @@ fn optimize_expr<'a>(expr: Expr, state: &mut State<'a>) -> Expr { }, // Do not call some special keywords - Expr::FunctionCall(id, args, def_value, pos) if DONT_EVAL_KEYWORDS.contains(&id.as_ref())=> - Expr::FunctionCall(id, Box::new(args.into_iter().map(|a| optimize_expr(a, state)).collect()), def_value, pos), + Expr::FnCall(id, args, def_value, pos) if DONT_EVAL_KEYWORDS.contains(&id.as_ref().as_ref())=> + Expr::FnCall(id, Box::new(args.into_iter().map(|a| optimize_expr(a, state)).collect()), def_value, pos), // Eagerly call functions - Expr::FunctionCall(id, args, def_value, pos) + Expr::FnCall(id, args, def_value, pos) if state.optimization_level == OptimizationLevel::Full // full optimizations && args.iter().all(|expr| expr.is_constant()) // all arguments are constants => { // First search in script-defined functions (can override built-in) - if state.fn_lib.iter().find(|(name, len)| name == &id && *len == args.len()).is_some() { + if state.fn_lib.iter().find(|(name, len)| name == id.as_ref() && *len == args.len()).is_some() { // A script-defined function overrides the built-in function - do not make the call - return Expr::FunctionCall(id, Box::new(args.into_iter().map(|a| optimize_expr(a, state)).collect()), def_value, pos); + return Expr::FnCall(id, Box::new(args.into_iter().map(|a| optimize_expr(a, state)).collect()), def_value, pos); } let mut arg_values: Vec<_> = args.iter().map(Expr::get_constant_value).collect(); @@ -577,7 +577,7 @@ fn optimize_expr<'a>(expr: Expr, state: &mut State<'a>) -> Expr { // Save the typename of the first argument if it is `type_of()` // This is to avoid `call_args` being passed into the closure - let arg_for_type_of = if id == KEYWORD_TYPE_OF && call_args.len() == 1 { + let arg_for_type_of = if *id == KEYWORD_TYPE_OF && call_args.len() == 1 { state.engine.map_type_name(call_args[0].type_name()) } else { "" @@ -600,13 +600,13 @@ fn optimize_expr<'a>(expr: Expr, state: &mut State<'a>) -> Expr { }) ).unwrap_or_else(|| // Optimize function call arguments - Expr::FunctionCall(id, Box::new(args.into_iter().map(|a| optimize_expr(a, state)).collect()), def_value, pos) + Expr::FnCall(id, Box::new(args.into_iter().map(|a| optimize_expr(a, state)).collect()), def_value, pos) ) } // id(args ..) -> optimize function call arguments - Expr::FunctionCall(id, args, def_value, pos) => - Expr::FunctionCall(id, Box::new(args.into_iter().map(|a| optimize_expr(a, state)).collect()), def_value, pos), + Expr::FnCall(id, args, def_value, pos) => + Expr::FnCall(id, Box::new(args.into_iter().map(|a| optimize_expr(a, state)).collect()), def_value, pos), // constant-name Expr::Variable(name, _, pos) if state.contains_constant(&name) => { diff --git a/src/parser.rs b/src/parser.rs index dccad46e..e682ee12 100644 --- a/src/parser.rs +++ b/src/parser.rs @@ -231,11 +231,11 @@ pub enum Stmt { /// loop { stmt } Loop(Box), /// for id in expr { stmt } - For(String, Box, Box), + For(Box, Box, Box), /// let id = expr - Let(String, Option>, Position), + Let(Box, Option>, Position), /// const id = expr - Const(String, Box, Position), + Const(Box, Box, Position), /// { stmt; ... } Block(Vec, Position), /// { stmt } @@ -317,7 +317,7 @@ pub enum Expr { /// String constant. StringConstant(String, Position), /// Variable access. - Variable(String, Option, Position), + Variable(Box, Option, Position), /// Property access. Property(String, Position), /// { stmt } @@ -325,8 +325,8 @@ pub enum Expr { /// func(expr, ... ) /// Use `Cow<'static, str>` because a lot of operators (e.g. `==`, `>=`) are implemented as function calls /// and the function names are predictable, so no need to allocate a new `String`. - FunctionCall( - Cow<'static, str>, + FnCall( + Box>, Box>, Option>, Position, @@ -427,7 +427,7 @@ impl Expr { | Self::Variable(_, _, pos) | Self::Property(_, pos) | Self::Stmt(_, pos) - | Self::FunctionCall(_, _, _, pos) + | Self::FnCall(_, _, _, pos) | Self::And(_, _, pos) | Self::Or(_, _, pos) | Self::In(_, _, pos) @@ -453,7 +453,7 @@ impl Expr { | Self::Variable(_, _, pos) | Self::Property(_, pos) | Self::Stmt(_, pos) - | Self::FunctionCall(_, _, _, pos) + | Self::FnCall(_, _, _, pos) | Self::And(_, _, pos) | Self::Or(_, _, pos) | Self::In(_, _, pos) @@ -530,7 +530,7 @@ impl Expr { Self::StringConstant(_, _) | Self::Stmt(_, _) - | Self::FunctionCall(_, _, _, _) + | Self::FnCall(_, _, _, _) | Self::Assignment(_, _, _) | Self::Dot(_, _, _) | Self::Index(_, _, _) @@ -550,7 +550,7 @@ impl Expr { /// Convert a `Variable` into a `Property`. All other variants are untouched. pub(crate) fn into_property(self) -> Self { match self { - Self::Variable(id, _, pos) => Self::Property(id, pos), + Self::Variable(id, _, pos) => Self::Property(*id, pos), _ => self, } } @@ -633,7 +633,12 @@ fn parse_call_expr<'a>( // id() (Token::RightParen, _) => { eat_token(input, Token::RightParen); - return Ok(Expr::FunctionCall(id.into(), Box::new(args), None, begin)); + return Ok(Expr::FnCall( + Box::new(id.into()), + Box::new(args), + None, + begin, + )); } // id... _ => (), @@ -645,7 +650,12 @@ fn parse_call_expr<'a>( match input.peek().unwrap() { (Token::RightParen, _) => { eat_token(input, Token::RightParen); - return Ok(Expr::FunctionCall(id.into(), Box::new(args), None, begin)); + return Ok(Expr::FnCall( + Box::new(id.into()), + Box::new(args), + None, + begin, + )); } (Token::Comma, _) => { eat_token(input, Token::Comma); @@ -968,7 +978,7 @@ fn parse_primary<'a>( Token::StringConst(s) => Expr::StringConstant(s, pos), Token::Identifier(s) => { let index = stack.find(&s); - Expr::Variable(s, index, pos) + Expr::Variable(Box::new(s), index, pos) } Token::LeftParen => parse_paren_expr(input, stack, pos, allow_stmt_expr)?, #[cfg(not(feature = "no_index"))] @@ -995,8 +1005,10 @@ fn parse_primary<'a>( root_expr = match (root_expr, token) { // Function call - (Expr::Variable(id, _, pos), Token::LeftParen) - | (Expr::Property(id, pos), Token::LeftParen) => { + (Expr::Variable(id, _, pos), Token::LeftParen) => { + parse_call_expr(input, stack, *id, pos, allow_stmt_expr)? + } + (Expr::Property(id, pos), Token::LeftParen) => { parse_call_expr(input, stack, id, pos, allow_stmt_expr)? } // Indexing @@ -1055,7 +1067,12 @@ fn parse_unary<'a>( Expr::FloatConstant(f, pos) => Ok(Expr::FloatConstant(-f, pos)), // Call negative function - e => Ok(Expr::FunctionCall("-".into(), Box::new(vec![e]), None, pos)), + e => Ok(Expr::FnCall( + Box::new("-".into()), + Box::new(vec![e]), + None, + pos, + )), } } // +expr @@ -1066,8 +1083,8 @@ fn parse_unary<'a>( // !expr (Token::Bang, _) => { let pos = eat_token(input, Token::Bang); - Ok(Expr::FunctionCall( - "!".into(), + Ok(Expr::FnCall( + Box::new("!".into()), Box::new(vec![parse_primary(input, stack, allow_stmt_expr)?]), Some(Box::new(false.into())), // NOT operator, when operating on invalid operand, defaults to false pos, @@ -1120,7 +1137,8 @@ fn parse_op_assignment_stmt<'a>( let rhs = parse_expr(input, stack, allow_stmt_expr)?; // lhs op= rhs -> lhs = op(lhs, rhs) - let rhs_expr = Expr::FunctionCall(op.into(), Box::new(vec![lhs_copy, rhs]), None, pos); + let args = vec![lhs_copy, rhs]; + let rhs_expr = Expr::FnCall(Box::new(op.into()), Box::new(args), None, pos); Ok(Expr::Assignment(Box::new(lhs), Box::new(rhs_expr), pos)) } @@ -1337,65 +1355,89 @@ fn parse_binary_op<'a>( let cmp_default = Some(Box::new(false.into())); current_lhs = match op_token { - Token::Plus => { - Expr::FunctionCall("+".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } - Token::Minus => { - Expr::FunctionCall("-".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } - Token::Multiply => { - Expr::FunctionCall("*".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } - Token::Divide => { - Expr::FunctionCall("/".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } + Token::Plus => Expr::FnCall( + Box::new("+".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), + Token::Minus => Expr::FnCall( + Box::new("-".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), + Token::Multiply => Expr::FnCall( + Box::new("*".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), + Token::Divide => Expr::FnCall( + Box::new("/".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), - Token::LeftShift => { - Expr::FunctionCall("<<".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } - Token::RightShift => { - Expr::FunctionCall(">>".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } - Token::Modulo => { - Expr::FunctionCall("%".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } - Token::PowerOf => { - Expr::FunctionCall("~".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } + Token::LeftShift => Expr::FnCall( + Box::new("<<".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), + Token::RightShift => Expr::FnCall( + Box::new(">>".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), + Token::Modulo => Expr::FnCall( + Box::new("%".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), + Token::PowerOf => Expr::FnCall( + Box::new("~".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), // Comparison operators default to false when passed invalid operands - Token::EqualsTo => Expr::FunctionCall( - "==".into(), + Token::EqualsTo => Expr::FnCall( + Box::new("==".into()), Box::new(vec![current_lhs, rhs]), cmp_default, pos, ), - Token::NotEqualsTo => Expr::FunctionCall( - "!=".into(), + Token::NotEqualsTo => Expr::FnCall( + Box::new("!=".into()), Box::new(vec![current_lhs, rhs]), cmp_default, pos, ), - Token::LessThan => Expr::FunctionCall( - "<".into(), + Token::LessThan => Expr::FnCall( + Box::new("<".into()), Box::new(vec![current_lhs, rhs]), cmp_default, pos, ), - Token::LessThanEqualsTo => Expr::FunctionCall( - "<=".into(), + Token::LessThanEqualsTo => Expr::FnCall( + Box::new("<=".into()), Box::new(vec![current_lhs, rhs]), cmp_default, pos, ), - Token::GreaterThan => Expr::FunctionCall( - ">".into(), + Token::GreaterThan => Expr::FnCall( + Box::new(">".into()), Box::new(vec![current_lhs, rhs]), cmp_default, pos, ), - Token::GreaterThanEqualsTo => Expr::FunctionCall( - ">=".into(), + Token::GreaterThanEqualsTo => Expr::FnCall( + Box::new(">=".into()), Box::new(vec![current_lhs, rhs]), cmp_default, pos, @@ -1403,15 +1445,24 @@ fn parse_binary_op<'a>( Token::Or => Expr::Or(Box::new(current_lhs), Box::new(rhs), pos), Token::And => Expr::And(Box::new(current_lhs), Box::new(rhs), pos), - Token::Ampersand => { - Expr::FunctionCall("&".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } - Token::Pipe => { - Expr::FunctionCall("|".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } - Token::XOr => { - Expr::FunctionCall("^".into(), Box::new(vec![current_lhs, rhs]), None, pos) - } + Token::Ampersand => Expr::FnCall( + Box::new("&".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), + Token::Pipe => Expr::FnCall( + Box::new("|".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), + Token::XOr => Expr::FnCall( + Box::new("^".into()), + Box::new(vec![current_lhs, rhs]), + None, + pos, + ), Token::In => make_in_expr(current_lhs, rhs, pos)?, @@ -1590,7 +1641,7 @@ fn parse_for<'a>( stack.rewind(prev_len); - Ok(Stmt::For(name, Box::new(expr), Box::new(body))) + Ok(Stmt::For(Box::new(name), Box::new(expr), Box::new(body))) } /// Parse a variable definition statement. @@ -1619,12 +1670,12 @@ fn parse_let<'a>( // let name = expr ScopeEntryType::Normal => { stack.push(name.clone()); - Ok(Stmt::Let(name, Some(Box::new(init_value)), pos)) + Ok(Stmt::Let(Box::new(name), Some(Box::new(init_value)), pos)) } // const name = { expr:constant } ScopeEntryType::Constant if init_value.is_constant() => { stack.push(name.clone()); - Ok(Stmt::Const(name, Box::new(init_value), pos)) + Ok(Stmt::Const(Box::new(name), Box::new(init_value), pos)) } // const name = expr - error ScopeEntryType::Constant => { @@ -1633,7 +1684,7 @@ fn parse_let<'a>( } } else { // let name - Ok(Stmt::Let(name, None, pos)) + Ok(Stmt::Let(Box::new(name), None, pos)) } }