From a6fa94d946391d6e47a4f729971202b93208352d Mon Sep 17 00:00:00 2001 From: Stephen Chung Date: Thu, 15 Oct 2020 14:36:10 +0800 Subject: [PATCH] Rhai function names with $ and . no longer fail. --- .../ui_tests/rhai_fn_rename_dollar_sign.rs | 28 ------------------- .../rhai_fn_rename_dollar_sign.stderr | 11 -------- codegen/ui_tests/rhai_fn_rename_dot.rs | 28 ------------------- codegen/ui_tests/rhai_fn_rename_dot.stderr | 11 -------- 4 files changed, 78 deletions(-) delete mode 100644 codegen/ui_tests/rhai_fn_rename_dollar_sign.rs delete mode 100644 codegen/ui_tests/rhai_fn_rename_dollar_sign.stderr delete mode 100644 codegen/ui_tests/rhai_fn_rename_dot.rs delete mode 100644 codegen/ui_tests/rhai_fn_rename_dot.stderr diff --git a/codegen/ui_tests/rhai_fn_rename_dollar_sign.rs b/codegen/ui_tests/rhai_fn_rename_dollar_sign.rs deleted file mode 100644 index 69af645c..00000000 --- a/codegen/ui_tests/rhai_fn_rename_dollar_sign.rs +++ /dev/null @@ -1,28 +0,0 @@ -use rhai::plugin::*; - -#[derive(Clone)] -pub struct Point { - x: f32, - y: f32, -} - -#[export_module] -pub mod test_module { - pub use super::Point; - #[rhai_fn(name = "big$caching")] - pub fn test_fn(input: Point) -> bool { - input.x > input.y - } -} - -fn main() { - let n = Point { - x: 0.0, - y: 10.0, - }; - if test_module::test_fn(n) { - println!("yes"); - } else { - println!("no"); - } -} diff --git a/codegen/ui_tests/rhai_fn_rename_dollar_sign.stderr b/codegen/ui_tests/rhai_fn_rename_dollar_sign.stderr deleted file mode 100644 index 3438bdfc..00000000 --- a/codegen/ui_tests/rhai_fn_rename_dollar_sign.stderr +++ /dev/null @@ -1,11 +0,0 @@ -error: Rhai function names may not contain dollar sign - --> $DIR/rhai_fn_rename_dollar_sign.rs:12:22 - | -12 | #[rhai_fn(name = "big$caching")] - | ^^^^^^^^^^^^^ - -error[E0433]: failed to resolve: use of undeclared crate or module `test_module` - --> $DIR/rhai_fn_rename_dollar_sign.rs:23:8 - | -23 | if test_module::test_fn(n) { - | ^^^^^^^^^^^ use of undeclared crate or module `test_module` diff --git a/codegen/ui_tests/rhai_fn_rename_dot.rs b/codegen/ui_tests/rhai_fn_rename_dot.rs deleted file mode 100644 index 9e2180d9..00000000 --- a/codegen/ui_tests/rhai_fn_rename_dot.rs +++ /dev/null @@ -1,28 +0,0 @@ -use rhai::plugin::*; - -#[derive(Clone)] -pub struct Point { - x: f32, - y: f32, -} - -#[export_module] -pub mod test_module { - pub use super::Point; - #[rhai_fn(name = "foo.bar")] - pub fn test_fn(input: Point) -> bool { - input.x > input.y - } -} - -fn main() { - let n = Point { - x: 0.0, - y: 10.0, - }; - if test_module::test_fn(n) { - println!("yes"); - } else { - println!("no"); - } -} diff --git a/codegen/ui_tests/rhai_fn_rename_dot.stderr b/codegen/ui_tests/rhai_fn_rename_dot.stderr deleted file mode 100644 index 964e1b34..00000000 --- a/codegen/ui_tests/rhai_fn_rename_dot.stderr +++ /dev/null @@ -1,11 +0,0 @@ -error: Rhai function names may not contain dot - --> $DIR/rhai_fn_rename_dot.rs:12:22 - | -12 | #[rhai_fn(name = "foo.bar")] - | ^^^^^^^^^ - -error[E0433]: failed to resolve: use of undeclared crate or module `test_module` - --> $DIR/rhai_fn_rename_dot.rs:23:8 - | -23 | if test_module::test_fn(n) { - | ^^^^^^^^^^^ use of undeclared crate or module `test_module`