From ec4522412089d2dfdd0dadbbcfa812a32d14a8b6 Mon Sep 17 00:00:00 2001 From: Stephen Chung Date: Sat, 10 Sep 2022 13:46:14 +0800 Subject: [PATCH 1/3] Fix sync feature. --- tests/closures.rs | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/closures.rs b/tests/closures.rs index 32d4b795..69df04e1 100644 --- a/tests/closures.rs +++ b/tests/closures.rs @@ -378,10 +378,8 @@ fn test_closures_external() -> Result<(), Box> { #[test] #[cfg(not(feature = "no_closure"))] +#[cfg(not(feature = "sync"))] fn test_closures_callback() -> Result<(), Box> { - use std::cell::RefCell; - use std::rc::Rc; - type SingleNode = Rc; trait Node { From 32825d2ca8a60a6050c33e36c1657719f61b1410 Mon Sep 17 00:00:00 2001 From: Stephen Chung Date: Sat, 10 Sep 2022 13:49:21 +0800 Subject: [PATCH 2/3] Fix feature build. --- src/module/mod.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/module/mod.rs b/src/module/mod.rs index 457402ad..ffb2bd82 100644 --- a/src/module/mod.rs +++ b/src/module/mod.rs @@ -1813,7 +1813,7 @@ impl Module { ) -> impl Iterator { self.iter_fn() .filter(|&f| f.func.is_script()) - .map(|f| (f.namespace, f.access, f.name.as_str(), f.params)) + .map(|f| (f.namespace, f.access, f.name.as_str(), f.num_params)) } /// _(internals)_ Get an iterator over all script-defined functions in the [`Module`]. From ea828262ba18052eabb7ccb48b522228e7a10a80 Mon Sep 17 00:00:00 2001 From: Stephen Chung Date: Sat, 10 Sep 2022 14:09:55 +0800 Subject: [PATCH 3/3] Remove nightly from CI. --- .github/workflows/build.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 64a543a1..3a30c812 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -66,11 +66,12 @@ jobs: toolchain: [stable] experimental: [false] include: - # smoketests for future and experimental toolchains + # smoketests for different toolchains - {toolchain: stable, os: windows-latest, experimental: false, flags: ""} - {toolchain: stable, os: macos-latest, experimental: false, flags: ""} - {toolchain: beta, os: ubuntu-latest, experimental: false, flags: ""} - - {toolchain: nightly, os: ubuntu-latest, experimental: true, flags: ""} + # nightly is a bit volatile + #- {toolchain: nightly, os: ubuntu-latest, experimental: true, flags: ""} fail-fast: false steps: - name: Checkout