diff --git a/codegen/src/module.rs b/codegen/src/module.rs index c1d7d6a3..30afc75c 100644 --- a/codegen/src/module.rs +++ b/codegen/src/module.rs @@ -150,7 +150,7 @@ impl Parse for Module { name: ident.to_string(), typ: ty.clone(), expr: expr.as_ref().clone(), - cfg_attrs: crate::attrs::collect_cfg_attr(&attrs), + cfg_attrs: crate::attrs::collect_cfg_attr(attrs), }), _ => {} } @@ -167,7 +167,7 @@ impl Parse for Module { }) => custom_types.push(ExportedType { name: ident.to_string(), typ: ty.clone(), - cfg_attrs: crate::attrs::collect_cfg_attr(&attrs), + cfg_attrs: crate::attrs::collect_cfg_attr(attrs), }), _ => {} } diff --git a/codegen/src/rhai_module.rs b/codegen/src/rhai_module.rs index 10b61e20..dc26e958 100644 --- a/codegen/src/rhai_module.rs +++ b/codegen/src/rhai_module.rs @@ -45,8 +45,8 @@ pub fn generate_body( .. } in consts { - let const_literal = syn::LitStr::new(&const_name, Span::call_site()); - let const_ref = syn::Ident::new(&const_name, Span::call_site()); + let const_literal = syn::LitStr::new(const_name, Span::call_site()); + let const_ref = syn::Ident::new(const_name, Span::call_site()); let cfg_attrs: Vec<_> = cfg_attrs .iter() @@ -69,7 +69,7 @@ pub fn generate_body( .. } in custom_types { - let const_literal = syn::LitStr::new(&name, Span::call_site()); + let const_literal = syn::LitStr::new(name, Span::call_site()); let cfg_attrs: Vec<_> = cfg_attrs .iter() @@ -86,7 +86,7 @@ pub fn generate_body( } for item_mod in sub_modules { - item_mod.update_scope(&parent_scope); + item_mod.update_scope(parent_scope); if item_mod.skipped() { continue; } @@ -117,7 +117,7 @@ pub fn generate_body( let mut gen_fn_tokens = Vec::new(); for function in fns { - function.update_scope(&parent_scope); + function.update_scope(parent_scope); if function.skipped() { continue; } diff --git a/src/api/custom_syntax.rs b/src/api/custom_syntax.rs index f1128604..4f2fb543 100644 --- a/src/api/custom_syntax.rs +++ b/src/api/custom_syntax.rs @@ -149,7 +149,7 @@ impl Expression<'_> { impl AsRef for Expression<'_> { #[inline(always)] fn as_ref(&self) -> &Expr { - &self.0 + self.0 } } @@ -158,7 +158,7 @@ impl Deref for Expression<'_> { #[inline(always)] fn deref(&self) -> &Self::Target { - &self.0 + self.0 } } @@ -178,7 +178,7 @@ impl Engine { /// /// Not available under `no_custom_syntax`. /// - /// * `symbols` holds a slice of strings that define the custom syntax. + /// * `symbols` holds a slice of strings that define the custom syntax. /// * `scope_may_be_changed` specifies variables _may_ be added/removed by this custom syntax. /// * `func` is the implementation function. /// diff --git a/src/engine.rs b/src/engine.rs index 10a80417..b6817419 100644 --- a/src/engine.rs +++ b/src/engine.rs @@ -335,7 +335,7 @@ impl Engine { } #[cfg(not(feature = "unchecked"))] - self.check_data_size(&r, _pos)?; + self.check_data_size(r, _pos)?; } _ => (), } diff --git a/src/eval/eval_context.rs b/src/eval/eval_context.rs index 3d83eb15..e57b87a2 100644 --- a/src/eval/eval_context.rs +++ b/src/eval/eval_context.rs @@ -190,7 +190,7 @@ impl<'a, 's, 'ps, 'g, 'pg, 'c, 'pc, 't, 'pt> EvalContext<'a, 's, 'ps, 'g, 'pg, ' caches, self.lib, self.this_ptr, - &statements, + statements, rewind_scope, self.level, ), diff --git a/src/eval/stmt.rs b/src/eval/stmt.rs index 03d36097..669db72c 100644 --- a/src/eval/stmt.rs +++ b/src/eval/stmt.rs @@ -161,7 +161,7 @@ impl Engine { ) { Ok(_) => { #[cfg(not(feature = "unchecked"))] - self.check_data_size(&args[0], root.1)?; + self.check_data_size(args[0], root.1)?; } Err(err) if matches!(*err, ERR::ErrorFunctionNotFound(ref f, ..) if f.starts_with(op_assign)) => { @@ -586,7 +586,7 @@ impl Engine { } let condition = self - .eval_expr(scope, global, caches, lib, this_ptr, &expr, level) + .eval_expr(scope, global, caches, lib, this_ptr, expr, level) .and_then(|v| { v.as_bool().map_err(|typ| { self.make_type_mismatch_err::(typ, expr.position()) @@ -952,7 +952,7 @@ impl Engine { } let path_result = self - .eval_expr(scope, global, caches, lib, this_ptr, &expr, level) + .eval_expr(scope, global, caches, lib, this_ptr, expr, level) .and_then(|v| { let typ = v.type_name(); v.try_cast::().ok_or_else(|| { diff --git a/src/func/call.rs b/src/func/call.rs index 6a0b05aa..6c17d422 100644 --- a/src/func/call.rs +++ b/src/func/call.rs @@ -281,7 +281,7 @@ impl Engine { return args.and_then(|args| { if !is_op_assignment { - get_builtin_binary_op_fn(fn_name, &args[0], &args[1]).map(|f| { + get_builtin_binary_op_fn(fn_name, args[0], args[1]).map(|f| { FnResolutionCacheEntry { func: CallableFunction::from_method( Box::new(f) as Box @@ -454,7 +454,7 @@ impl Engine { // Check the data size of any `&mut` object, which may be changed. #[cfg(not(feature = "unchecked"))] if is_ref_mut && args.len() > 0 { - self.check_data_size(&args[0], pos)?; + self.check_data_size(args[0], pos)?; } // See if the function match print/debug (which requires special processing) @@ -464,7 +464,7 @@ impl Engine { let t = self.map_type_name(type_name::()).into(); ERR::ErrorMismatchOutputType(t, typ.into(), pos) })?; - ((&*self.print)(&text).into(), false) + ((*self.print)(&text).into(), false) } KEYWORD_DEBUG => { let text = result.into_immutable_string().map_err(|typ| { @@ -476,7 +476,7 @@ impl Engine { } else { Some(global.source.as_str()) }; - ((&*self.debug)(&text, source, pos).into(), false) + ((*self.debug)(&text, source, pos).into(), false) } _ => (result, is_method), }); diff --git a/src/module/mod.rs b/src/module/mod.rs index 65c61253..c2ebf1b5 100644 --- a/src/module/mod.rs +++ b/src/module/mod.rs @@ -90,7 +90,7 @@ pub struct FuncInfo { impl FuncInfo { /// Format a return type to be display-friendly. /// - /// `()` is cleared. + /// `()` is cleared. /// [`RhaiResult`][crate::RhaiResult] and [`RhaiResultOf`] are expanded. #[cfg(feature = "metadata")] pub fn format_type(typ: &str, is_return_type: bool) -> std::borrow::Cow { @@ -1860,7 +1860,7 @@ impl Module { let orig_constants = std::mem::take(&mut global.constants); // Run the script - let result = engine.eval_ast_with_scope_raw(&mut scope, global, &ast, 0); + let result = engine.eval_ast_with_scope_raw(&mut scope, global, ast, 0); // Create new module let mut module = Module::new(); diff --git a/src/optimizer.rs b/src/optimizer.rs index 79a02b8a..2fb671ec 100644 --- a/src/optimizer.rs +++ b/src/optimizer.rs @@ -151,7 +151,7 @@ impl<'a> OptimizerState<'a> { &mut self.caches, lib, fn_name, - calc_fn_hash(&fn_name, arg_values.len()), + calc_fn_hash(fn_name, arg_values.len()), &mut arg_values.iter_mut().collect::>(), false, false, @@ -1416,7 +1416,7 @@ pub fn optimize_into_ast( OptimizationLevel::Simple | OptimizationLevel::Full => optimize_top_level( statements, engine, - &scope, + scope, #[cfg(not(feature = "no_function"))] &[&lib], optimization_level, diff --git a/src/types/dynamic.rs b/src/types/dynamic.rs index b596923a..8a6e1fa2 100644 --- a/src/types/dynamic.rs +++ b/src/types/dynamic.rs @@ -218,7 +218,7 @@ impl<'d, T: Any + Clone> Deref for DynamicReadLock<'d, T> { #[inline] fn deref(&self) -> &Self::Target { match self.0 { - DynamicReadLockInner::Reference(ref reference) => *reference, + DynamicReadLockInner::Reference(reference) => reference, #[cfg(not(feature = "no_closure"))] DynamicReadLockInner::Guard(ref guard) => guard.downcast_ref().expect(CHECKED), } diff --git a/src/types/fn_ptr.rs b/src/types/fn_ptr.rs index 719e8b0f..6b8d6254 100644 --- a/src/types/fn_ptr.rs +++ b/src/types/fn_ptr.rs @@ -181,7 +181,7 @@ impl FnPtr { let mut arg_values = crate::StaticVec::new_const(); args.parse(&mut arg_values); - let result = self.call_raw(&context, None, arg_values)?; + let result = self.call_raw(context, None, arg_values)?; let typ = context.engine().map_type_name(result.type_name());