feat: truly cancel if revision isn't as expected
Some checks failed
continuous-integration/drone/push Build is failing
Some checks failed
continuous-integration/drone/push Build is failing
Signed-off-by: kjuulh <contact@kjuulh.io>
This commit is contained in:
@@ -87,16 +87,20 @@ impl BackendEdge for PostgresBackend {
|
|||||||
FROM noleader_leaders
|
FROM noleader_leaders
|
||||||
WHERE
|
WHERE
|
||||||
key = $1
|
key = $1
|
||||||
|
AND revision = $2
|
||||||
AND heartbeat >= now() - interval '60 seconds'
|
AND heartbeat >= now() - interval '60 seconds'
|
||||||
LIMIT 1;
|
LIMIT 1;
|
||||||
",
|
",
|
||||||
)
|
)
|
||||||
.bind(&key.0)
|
.bind(&key.0)
|
||||||
|
.bind(self.revision.load(Ordering::Relaxed) as i64)
|
||||||
.fetch_optional(&self.db().await?)
|
.fetch_optional(&self.db().await?)
|
||||||
.await
|
.await
|
||||||
.context("get noleader key")?;
|
.context("get noleader key")?;
|
||||||
|
|
||||||
let Some(val) = rec else {
|
let Some(val) = rec else {
|
||||||
|
self.revision.store(0, Ordering::Relaxed);
|
||||||
|
|
||||||
anyhow::bail!("key doesn't exist, we've lost leadership status")
|
anyhow::bail!("key doesn't exist, we've lost leadership status")
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -105,6 +109,7 @@ impl BackendEdge for PostgresBackend {
|
|||||||
|
|
||||||
let Ok(id) = uuid::Uuid::parse_str(&val.value) else {
|
let Ok(id) = uuid::Uuid::parse_str(&val.value) else {
|
||||||
tracing::warn!("value is not a valid uuid: {}", val.value);
|
tracing::warn!("value is not a valid uuid: {}", val.value);
|
||||||
|
self.revision.store(0, Ordering::Relaxed);
|
||||||
return Ok(LeaderValue::Unknown);
|
return Ok(LeaderValue::Unknown);
|
||||||
};
|
};
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user