From 8f50fb6793a6c2df4b46855feba055827dc9c4e9 Mon Sep 17 00:00:00 2001 From: Suhas Karanth Date: Fri, 17 Jan 2020 10:25:50 +0530 Subject: [PATCH] Avoid deprecated LoadModes packages.{LoadFiles, LoadSyntax} (#116) From the docs for packages.{LoadFiles, LoadSyntax} - https://godoc.org/golang.org/x/tools/go/packages#pkg-constants // Deprecated: LoadFiles exists for historical compatibility // and should not be used. Please directly specify the needed // fields using the Need values. // ... // Deprecated: LoadSyntax exists for historical compatibility // and should not be used. Please directly specify the needed // fields using the Need values. --- .gitignore | 1 + pkg/moq/moq.go | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index b15784e..016a02d 100644 --- a/.gitignore +++ b/.gitignore @@ -23,3 +23,4 @@ _testmain.go *.test *.prof .vscode +.idea diff --git a/pkg/moq/moq.go b/pkg/moq/moq.go index 971c942..c293e4d 100644 --- a/pkg/moq/moq.go +++ b/pkg/moq/moq.go @@ -71,7 +71,7 @@ type Mocker struct { // New makes a new Mocker for the specified package directory. func New(src, packageName string) (*Mocker, error) { - srcPkg, err := pkgInfoFromPath(src, packages.LoadSyntax) + srcPkg, err := pkgInfoFromPath(src, packages.NeedName|packages.NeedTypes|packages.NeedTypesInfo) if err != nil { return nil, fmt.Errorf("couldn't load source package: %s", err) } @@ -118,7 +118,7 @@ func findPkgPath(pkgInputVal string, srcPkg *packages.Package) (string, error) { } func pkgInDir(pkgName, dir string) bool { - currentPkg, err := pkgInfoFromPath(dir, packages.LoadFiles) + currentPkg, err := pkgInfoFromPath(dir, packages.NeedName) if err != nil { return false }