From ebe26a90ca0efd76bcfaf1177fb74178cf259dc0 Mon Sep 17 00:00:00 2001
From: Tom Chauveau <tom.chauveau@epitech.eu>
Date: Sat, 22 May 2021 16:49:57 +0200
Subject: [PATCH] Move random string generation to his own file to avoid
 replication in tests.

Signed-off-by: Tom Chauveau <tom.chauveau@epitech.eu>
---
 tests/ops/push-container/main.cue           | 28 ---------------------
 tests/ops/push-container/random.cue         | 20 +++++++++++++++
 tests/stdlib/aws/ecr/ecr.cue                | 15 -----------
 tests/stdlib/aws/ecr/random.cue             | 20 +++++++++++++++
 tests/stdlib/docker/push-pull/push-pull.cue | 14 -----------
 tests/stdlib/docker/push-pull/random.cue    | 20 +++++++++++++++
 tests/stdlib/gcp/gcr/gcr.cue                | 15 -----------
 tests/stdlib/gcp/gcr/random.cue             | 20 +++++++++++++++
 tests/stdlib/kubernetes/helm/helm.cue       | 16 ------------
 tests/stdlib/kubernetes/helm/random.cue     | 20 +++++++++++++++
 tests/stdlib/kubernetes/kubernetes.cue      | 18 -------------
 tests/stdlib/kubernetes/random.cue          | 20 +++++++++++++++
 tests/stdlib/netlify/netlify.cue            | 14 -----------
 tests/stdlib/netlify/random.cue             | 20 +++++++++++++++
 14 files changed, 140 insertions(+), 120 deletions(-)
 create mode 100644 tests/ops/push-container/random.cue
 create mode 100644 tests/stdlib/aws/ecr/random.cue
 create mode 100644 tests/stdlib/docker/push-pull/random.cue
 create mode 100644 tests/stdlib/gcp/gcr/random.cue
 create mode 100644 tests/stdlib/kubernetes/helm/random.cue
 create mode 100644 tests/stdlib/kubernetes/random.cue
 create mode 100644 tests/stdlib/netlify/random.cue

diff --git a/tests/ops/push-container/main.cue b/tests/ops/push-container/main.cue
index 80db13f1..212afee5 100644
--- a/tests/ops/push-container/main.cue
+++ b/tests/ops/push-container/main.cue
@@ -12,20 +12,6 @@ registry: {
 }
 
 TestPushContainer: {
-	// Generate a random number
-	random: {
-		string
-		#up: [
-			op.#Load & {from: alpine.#Image},
-			op.#Exec & {
-				args: ["sh", "-c", "echo -n $RANDOM > /rand"]
-			},
-			op.#Export & {
-				source: "/rand"
-			},
-		]
-	}
-
 	// Push an image with a random tag
 	push: {
 		ref: "daggerio/ci-test:\(random)"
@@ -66,20 +52,6 @@ TestPushContainer: {
 
 // Ensures image metadata is preserved in a push
 TestPushContainerMetadata: {
-	// Generate a random number
-	random: {
-		string
-		#up: [
-			op.#Load & {from: alpine.#Image},
-			op.#Exec & {
-				args: ["sh", "-c", "echo -n $RANDOM > /rand"]
-			},
-			op.#Export & {
-				source: "/rand"
-			},
-		]
-	}
-
 	// `docker build` using an `ENV` and push the image
 	push: {
 		ref: "daggerio/ci-test:\(random)-dockerbuild"
diff --git a/tests/ops/push-container/random.cue b/tests/ops/push-container/random.cue
new file mode 100644
index 00000000..9df9428d
--- /dev/null
+++ b/tests/ops/push-container/random.cue
@@ -0,0 +1,20 @@
+package testing
+
+import (
+	"dagger.io/alpine"
+	"dagger.io/dagger/op"
+)
+
+// Generate a random number
+random: {
+	string
+	#up: [
+		op.#Load & {from: alpine.#Image},
+		op.#Exec & {
+			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
+		},
+		op.#Export & {
+			source: "/rand"
+		},
+	]
+}
diff --git a/tests/stdlib/aws/ecr/ecr.cue b/tests/stdlib/aws/ecr/ecr.cue
index 0399c080..ca0e77db 100644
--- a/tests/stdlib/aws/ecr/ecr.cue
+++ b/tests/stdlib/aws/ecr/ecr.cue
@@ -3,7 +3,6 @@ package ecr
 import (
 	"dagger.io/aws"
 	"dagger.io/aws/ecr"
-	"dagger.io/alpine"
 	"dagger.io/dagger/op"
 )
 
@@ -11,20 +10,6 @@ TestConfig: awsConfig: aws.#Config & {
 	region: "us-east-2"
 }
 
-// Generate a random number
-random: {
-	string
-	#up: [
-		op.#Load & {from: alpine.#Image},
-		op.#Exec & {
-			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
-		},
-		op.#Export & {
-			source: "/rand"
-		},
-	]
-}
-
 TestECR: {
 	repository: "125635003186.dkr.ecr.\(TestConfig.awsConfig.region).amazonaws.com/dagger-ci"
 	tag:        "test-ecr-\(random)"
diff --git a/tests/stdlib/aws/ecr/random.cue b/tests/stdlib/aws/ecr/random.cue
new file mode 100644
index 00000000..4e8bacfa
--- /dev/null
+++ b/tests/stdlib/aws/ecr/random.cue
@@ -0,0 +1,20 @@
+package ecr
+
+import (
+	"dagger.io/alpine"
+	"dagger.io/dagger/op"
+)
+
+// Generate a random number
+random: {
+	string
+	#up: [
+		op.#Load & {from: alpine.#Image},
+		op.#Exec & {
+			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
+		},
+		op.#Export & {
+			source: "/rand"
+		},
+	]
+}
diff --git a/tests/stdlib/docker/push-pull/push-pull.cue b/tests/stdlib/docker/push-pull/push-pull.cue
index 6dfee310..0487db70 100644
--- a/tests/stdlib/docker/push-pull/push-pull.cue
+++ b/tests/stdlib/docker/push-pull/push-pull.cue
@@ -15,20 +15,6 @@ registry: {
 }
 
 TestPushAndPull: {
-	// Generate a random number
-	random: {
-		string
-		#up: [
-			op.#Load & {from: alpine.#Image},
-			op.#Exec & {
-				args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
-			},
-			op.#Export & {
-				source: "/rand"
-			},
-		]
-	}
-
 	ref: "daggerio/ci-test:\(random)"
 
 	// Create image
diff --git a/tests/stdlib/docker/push-pull/random.cue b/tests/stdlib/docker/push-pull/random.cue
new file mode 100644
index 00000000..e09ce830
--- /dev/null
+++ b/tests/stdlib/docker/push-pull/random.cue
@@ -0,0 +1,20 @@
+package docker
+
+import (
+	"dagger.io/alpine"
+	"dagger.io/dagger/op"
+)
+
+// Generate a random number
+random: {
+	string
+	#up: [
+		op.#Load & {from: alpine.#Image},
+		op.#Exec & {
+			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
+		},
+		op.#Export & {
+			source: "/rand"
+		},
+	]
+}
diff --git a/tests/stdlib/gcp/gcr/gcr.cue b/tests/stdlib/gcp/gcr/gcr.cue
index e33f6547..68d056b5 100644
--- a/tests/stdlib/gcp/gcr/gcr.cue
+++ b/tests/stdlib/gcp/gcr/gcr.cue
@@ -3,26 +3,11 @@ package gcr
 import (
 	"dagger.io/gcp"
 	"dagger.io/gcp/gcr"
-	"dagger.io/alpine"
 	"dagger.io/dagger/op"
 )
 
 TestConfig: gcpConfig: gcp.#Config
 
-// Generate a random number
-random: {
-	string
-	#up: [
-		op.#Load & {from: alpine.#Image},
-		op.#Exec & {
-			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
-		},
-		op.#Export & {
-			source: "/rand"
-		},
-	]
-}
-
 TestGCR: {
 	repository: "gcr.io/dagger-ci/test"
 	tag:        "test-gcr-\(random)"
diff --git a/tests/stdlib/gcp/gcr/random.cue b/tests/stdlib/gcp/gcr/random.cue
new file mode 100644
index 00000000..cac0cf10
--- /dev/null
+++ b/tests/stdlib/gcp/gcr/random.cue
@@ -0,0 +1,20 @@
+package gcr
+
+import (
+	"dagger.io/alpine"
+	"dagger.io/dagger/op"
+)
+
+// Generate a random number
+random: {
+	string
+	#up: [
+		op.#Load & {from: alpine.#Image},
+		op.#Exec & {
+			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
+		},
+		op.#Export & {
+			source: "/rand"
+		},
+	]
+}
diff --git a/tests/stdlib/kubernetes/helm/helm.cue b/tests/stdlib/kubernetes/helm/helm.cue
index 3898d900..d98a543e 100644
--- a/tests/stdlib/kubernetes/helm/helm.cue
+++ b/tests/stdlib/kubernetes/helm/helm.cue
@@ -2,8 +2,6 @@ package helm
 
 import (
 	"dagger.io/dagger"
-	"dagger.io/dagger/op"
-	"dagger.io/alpine"
 	"dagger.io/file"
 	"dagger.io/kubernetes/helm"
 )
@@ -18,20 +16,6 @@ config: file.#Read & {
 	from:     kubeconfig
 }
 
-// Generate random string
-random: {
-	string
-	#up: [
-		op.#Load & {from: alpine.#Image},
-		op.#Exec & {
-			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
-		},
-		op.#Export & {
-			source: "/rand"
-		},
-	]
-}
-
 // Deploy user local chart
 TestHelmSimpleChart: {
 	// Deploy chart
diff --git a/tests/stdlib/kubernetes/helm/random.cue b/tests/stdlib/kubernetes/helm/random.cue
new file mode 100644
index 00000000..f3b9aedb
--- /dev/null
+++ b/tests/stdlib/kubernetes/helm/random.cue
@@ -0,0 +1,20 @@
+package helm
+
+import (
+	"dagger.io/alpine"
+	"dagger.io/dagger/op"
+)
+
+// Generate a random number
+random: {
+	string
+	#up: [
+		op.#Load & {from: alpine.#Image},
+		op.#Exec & {
+			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
+		},
+		op.#Export & {
+			source: "/rand"
+		},
+	]
+}
diff --git a/tests/stdlib/kubernetes/kubernetes.cue b/tests/stdlib/kubernetes/kubernetes.cue
index bdfde2f1..877d5455 100644
--- a/tests/stdlib/kubernetes/kubernetes.cue
+++ b/tests/stdlib/kubernetes/kubernetes.cue
@@ -3,8 +3,6 @@ package kubernetes
 import (
 	"encoding/yaml"
 	"dagger.io/dagger"
-	"dagger.io/dagger/op"
-	"dagger.io/alpine"
 	"dagger.io/file"
 	"dagger.io/kubernetes"
 )
@@ -19,22 +17,6 @@ config: file.#Read & {
 	from:     kubeconfig
 }
 
-// Generate a random number
-// It trigger a "cycle error" if I put it in TestKubeApply ?!
-// failed to up deployment: buildkit solve: TestKubeApply.#up: cycle error
-random: {
-	string
-	#up: [
-		op.#Load & {from: alpine.#Image},
-		op.#Exec & {
-			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
-		},
-		op.#Export & {
-			source: "/rand"
-		},
-	]
-}
-
 TestKubeApply: {
 	// Pod spec
 	kubeSrc: {
diff --git a/tests/stdlib/kubernetes/random.cue b/tests/stdlib/kubernetes/random.cue
new file mode 100644
index 00000000..758af399
--- /dev/null
+++ b/tests/stdlib/kubernetes/random.cue
@@ -0,0 +1,20 @@
+package kubernetes
+
+import (
+	"dagger.io/alpine"
+	"dagger.io/dagger/op"
+)
+
+// Generate a random number
+random: {
+	string
+	#up: [
+		op.#Load & {from: alpine.#Image},
+		op.#Exec & {
+			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
+		},
+		op.#Export & {
+			source: "/rand"
+		},
+	]
+}
diff --git a/tests/stdlib/netlify/netlify.cue b/tests/stdlib/netlify/netlify.cue
index 68683cfe..f84a27da 100644
--- a/tests/stdlib/netlify/netlify.cue
+++ b/tests/stdlib/netlify/netlify.cue
@@ -7,20 +7,6 @@ import (
 )
 
 TestNetlify: {
-	// Generate a random number
-	random: {
-		string
-		#up: [
-			op.#Load & {from: alpine.#Image},
-			op.#Exec & {
-				args: ["sh", "-c", "echo -n $RANDOM > /rand"]
-			},
-			op.#Export & {
-				source: "/rand"
-			},
-		]
-	}
-
 	// Generate a website containing the random number
 	html: #up: [
 		op.#WriteFile & {
diff --git a/tests/stdlib/netlify/random.cue b/tests/stdlib/netlify/random.cue
new file mode 100644
index 00000000..a9c5c710
--- /dev/null
+++ b/tests/stdlib/netlify/random.cue
@@ -0,0 +1,20 @@
+package netlify
+
+import (
+	"dagger.io/alpine"
+	"dagger.io/dagger/op"
+)
+
+// Generate a random number
+random: {
+	string
+	#up: [
+		op.#Load & {from: alpine.#Image},
+		op.#Exec & {
+			args: ["sh", "-c", "cat /dev/urandom | tr -dc 'a-z' | fold -w 10 | head -n 1 | tr -d '\n' > /rand"]
+		},
+		op.#Export & {
+			source: "/rand"
+		},
+	]
+}