kjuulh/dagger
Archived
1
0
Fork 0
Code Issues 1 Pull Requests 1 Projects Releases Wiki Activity

fixed inputs when input target is overriden

Browse Source 
Signed-off-by: Sam Alba <sam.alba@gmail.com>
This commit is contained in:
Sam Alba
2021-04-02 16:29:34 -07:00
parent a24dbef0b7
commit d3fc31ab57
5 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
dagger/deployment.go
View File

@@ -40,7 +40,15 @@ type inputKV struct {
Value Input `json:"value,omitempty"`
}
func (s *DeploymentState) AddInput(key string, value Input) error {
func (s *DeploymentState) SetInput(key string, value Input) error {
for i, inp := range s.Inputs {
if inp.Key != key {
continue
}
// Remove existing inputs with the same key
s.Inputs = append(s.Inputs[:i], s.Inputs[i+1:]...)
}
s.Inputs = append(s.Inputs, inputKV{Key: key, Value: value})
return nil
}

2
dagger/input_test.go
View File

@@ -10,7 +10,7 @@ func TestInputDir(t *testing.T) {
st := &DeploymentState{
PlanSource: DirInput("/tmp/source", []string{}),
}
require.NoError(t, st.AddInput("www.source", DirInput(".", []string{})))
require.NoError(t, st.SetInput("www.source", DirInput(".", []string{})))
deployment, err := NewDeployment(st)
require.NoError(t, err)

4
dagger/store_test.go
View File

@@ -62,7 +62,7 @@ func TestStoreLookupByPath(t *testing.T) {
st := &DeploymentState{
Name: "test",
}
require.NoError(t, st.AddInput("foo", DirInput("/test/path", []string{})))
require.NoError(t, st.SetInput("foo", DirInput("/test/path", []string{})))
require.NoError(t, store.CreateDeployment(ctx, st))
// Lookup by path
@@ -72,7 +72,7 @@ func TestStoreLookupByPath(t *testing.T) {
require.Equal(t, st.ID, r.ID)
// Add a new path
require.NoError(t, st.AddInput("bar", DirInput("/test/anotherpath", []string{})))
require.NoError(t, st.SetInput("bar", DirInput("/test/anotherpath", []string{})))
require.NoError(t, store.UpdateDeployment(ctx, st, nil))
// Lookup by the previous path