From 7484df45cd690a6ff5c234ef943d0f0faf9ff48b Mon Sep 17 00:00:00 2001 From: Sam Alba Date: Fri, 21 May 2021 16:56:30 -0700 Subject: [PATCH] clean up comments Signed-off-by: Sam Alba --- dagger/inputs_scan.go | 2 ++ stdlib/dagger/dagger.cue | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/dagger/inputs_scan.go b/dagger/inputs_scan.go index 50edfa7f..a76f54a1 100644 --- a/dagger/inputs_scan.go +++ b/dagger/inputs_scan.go @@ -11,11 +11,13 @@ func isReference(val *compiler.Value) bool { _, ref := val.ReferencePath() if ref.String() == "" || val.Path().String() == ref.String() { + // not a reference return false } for _, s := range ref.Selectors() { if s.IsDefinition() { + // if we reference to a definition, we skip the check return false } } diff --git a/stdlib/dagger/dagger.cue b/stdlib/dagger/dagger.cue index ff67e740..3f9bcdd2 100644 --- a/stdlib/dagger/dagger.cue +++ b/stdlib/dagger/dagger.cue @@ -7,7 +7,6 @@ import ( // An artifact such as source code checkout, container image, binary archive... // May be passed as user input, or computed by a buildkit pipeline -// FIXME (perf). See https://github.com/dagger/dagger/issues/445 #Artifact: { @dagger(artifact) #up: [...op.#Op]