From 8a7b5e1b6303970908b34a07fd70e6a27b3d8c74 Mon Sep 17 00:00:00 2001 From: Tom Chauveau Date: Fri, 20 Aug 2021 17:06:22 +0200 Subject: [PATCH] Fix env & log global flags are no longer hidden. There was a hack in `version.go` that was hiding unused flag from that command. The problem is that the effect has spread to all commands. I've removed that trick to correctly display all flags because it's important for users to know how select an environment and configure log format. Signed-off-by: Tom Chauveau --- cmd/dagger/cmd/version.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/cmd/dagger/cmd/version.go b/cmd/dagger/cmd/version.go index 3537cc95..7979e252 100644 --- a/cmd/dagger/cmd/version.go +++ b/cmd/dagger/cmd/version.go @@ -59,10 +59,6 @@ var versionCmd = &cobra.Command{ func init() { versionCmd.Flags().Bool("check", false, "check if dagger is up to date") - versionCmd.InheritedFlags().MarkHidden("environment") - versionCmd.InheritedFlags().MarkHidden("log-level") - versionCmd.InheritedFlags().MarkHidden("log-format") - if err := viper.BindPFlags(versionCmd.Flags()); err != nil { panic(err) }