feat: with dagger-engine v.0.4.0

ARCHITECTURE.md

@@ -1,12 +0,0 @@
-# Architecture
-
-- `.` Root project mainly used for generating the CLI, which in turn is used to
-  bootstrap the code generation from `dagger`
-- `crates/dagger-core` Contains all base types used during actual usage. This is
-  where the primary logic lives in which the user interacts (\*disclaimer: most
-  stuff haven't moved in here yet.)
-- `crates/dagger-sdk` Contains the actual sdk in which the user interacts,
-  `dagger-core` is reexported through this API as well.
-- `crates/dagger-codegen` This is the bulk of the work, it takes the input
-  graphql and spits out the API in which the user interacts, this is heavily
-  inspired by other `dagger-sdk's`. It primarily turns graphql into rust code.

CONTRIBUTING.md

@@ -1,11 +0,0 @@
-# Contributing
-
-The sdk is still quite young, so feel free to either:
-
-- Refactor
-- Document
-- Improve the code
-
-Feel free to ping me on discord @Hermansen#4325, or just create an issue if
-there is a missing feature, or you'd like some mentorship in getting into the
-code

Cargo.lock

@@ -260,7 +260,7 @@ dependencies = [
 
 [[package]]
 name = "dagger-core"
-version = "0.2.8"
+version = "0.2.7"
 dependencies = [
  "clap",
  "dirs",
@@ -309,7 +309,7 @@ dependencies = [
 
 [[package]]
 name = "dagger-sdk"
-version = "0.2.18"
+version = "0.2.15"
 dependencies = [
  "base64",
  "dagger-core",
@@ -537,9 +537,9 @@ dependencies = [
 
 [[package]]
 name = "futures"
-version = "0.3.27"
+version = "0.3.26"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "531ac96c6ff5fd7c62263c5e3c67a603af4fcaee2e1a0ae5565ba3a11e69e549"
+checksum = "13e2792b0ff0340399d58445b88fd9770e3489eff258a4cbc1523418f12abf84"
 dependencies = [
  "futures-channel",
  "futures-core",
@@ -552,9 +552,9 @@ dependencies = [
 
 [[package]]
 name = "futures-channel"
-version = "0.3.27"
+version = "0.3.26"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "164713a5a0dcc3e7b4b1ed7d3b433cabc18025386f9339346e8daf15963cf7ac"
+checksum = "2e5317663a9089767a1ec00a487df42e0ca174b61b4483213ac24448e4664df5"
 dependencies = [
  "futures-core",
  "futures-sink",
@@ -562,15 +562,15 @@ dependencies = [
 
 [[package]]
 name = "futures-core"
-version = "0.3.27"
+version = "0.3.26"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "86d7a0c1aa76363dac491de0ee99faf6941128376f1cf96f07db7603b7de69dd"
+checksum = "ec90ff4d0fe1f57d600049061dc6bb68ed03c7d2fbd697274c41805dcb3f8608"
 
 [[package]]
 name = "futures-executor"
-version = "0.3.27"
+version = "0.3.26"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "1997dd9df74cdac935c76252744c1ed5794fac083242ea4fe77ef3ed60ba0f83"
+checksum = "e8de0a35a6ab97ec8869e32a2473f4b1324459e14c29275d14b10cb1fd19b50e"
 dependencies = [
  "futures-core",
  "futures-task",
@@ -579,15 +579,15 @@ dependencies = [
 
 [[package]]
 name = "futures-io"
-version = "0.3.27"
+version = "0.3.26"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "89d422fa3cbe3b40dca574ab087abb5bc98258ea57eea3fd6f1fa7162c778b91"
+checksum = "bfb8371b6fb2aeb2d280374607aeabfc99d95c72edfe51692e42d3d7f0d08531"
 
 [[package]]
 name = "futures-macro"
-version = "0.3.27"
+version = "0.3.26"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3eb14ed937631bd8b8b8977f2c198443447a8355b6e3ca599f38c975e5a963b6"
+checksum = "95a73af87da33b5acf53acfebdc339fe592ecf5357ac7c0a7734ab9d8c876a70"
 dependencies = [
  "proc-macro2",
  "quote",
@@ -596,21 +596,21 @@ dependencies = [
 
 [[package]]
 name = "futures-sink"
-version = "0.3.27"
+version = "0.3.26"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ec93083a4aecafb2a80a885c9de1f0ccae9dbd32c2bb54b0c3a65690e0b8d2f2"
+checksum = "f310820bb3e8cfd46c80db4d7fb8353e15dfff853a127158425f31e0be6c8364"
 
 [[package]]
 name = "futures-task"
-version = "0.3.27"
+version = "0.3.26"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "fd65540d33b37b16542a0438c12e6aeead10d4ac5d05bd3f805b8f35ab592879"
+checksum = "dcf79a1bf610b10f42aea489289c5a2c478a786509693b80cd39c44ccd936366"
 
 [[package]]
 name = "futures-util"
-version = "0.3.27"
+version = "0.3.26"
 source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "3ef6b17e481503ec85211fed8f39d1970f128935ca1f814cd32ac4a6842e84ab"
+checksum = "9c1d6de3acfef38d2be4b1f543f553131788603495be83da675e180c8d6b7bd1"
 dependencies = [
  "futures-channel",
  "futures-core",

Cargo.toml

@@ -20,7 +20,7 @@ members = [
 
 [dependencies]
 dagger-codegen = { path = "crates/dagger-codegen", version = "^0.2.5" }
-dagger-core = { path = "crates/dagger-core", version = "^0.2.8" }
+dagger-core = { path = "crates/dagger-core", version = "^0.2.7" }
 
 clap = "4.1.6"
 dirs = "4.0.0"

Makefile.toml

@@ -2,42 +2,3 @@
 command = "cargo"
 args = ["run", "-p", "ci", "--", "codegen"]
 workspace = false
-
-[tasks.build]
-command = "cargo"
-args = ["run", "-p", "ci", "--", "ci"]
-dependencies = ["codegen"]
-workspace = false
-
-[tasks.fmt]
-command = "cargo"
-args = ["fmt", "--all"]
-workspace = false
-
-[tasks.fix]
-command = "cargo"
-args = ["fix", "--workspace", "--allow-dirty"]
-dependencies = ["fmt"]
-workspace = false
-
-[tasks.release_crate]
-command = "cargo"
-args = [
-  "smart-release",
-  "--allow-fully-generated-changelogs",
-  "--update-crates-index",
-  "dagger-sdk",
-]
-dependencies = ["codegen", "fix"]
-workspace = false
-
-[tasks.release_crate_commit]
-command = "cargo"
-args = [
-  "smart-release",
-  "-e",
-  "--allow-fully-generated-changelogs",
-  "--update-crates-index",
-  "dagger-sdk",
-]
-workspace = false

README.md

@@ -1,55 +1,40 @@
-# dagger-sdk
+# dagger-rs
 
 A dagger sdk written in rust for rust.
 
-## Examples
+# Usage
 
-See [examples](./crates/dagger-sdk/examples/)
+See [dagger-sdk](./crates/dagger-sdk/README.md)
 
-Run them like so
+### Status
 
-```bash
+- [x] dagger cli downloader
-cargo run --example first-pipeline
+- [x] dagger network session
-```
+- [x] graphql rust codegen (User API)
+  - [x] Scalars
+  - [x] Enums
+  - [x] Input
+  - [x] Objects
+- [x] Implement context and querier
+  - [x] Marshaller
+  - [x] Querier
+  - [x] Context
+  - [x] Deserializer for nested response (bind)
+- [x] Add codegen to hook into querier
+- [x] fix build / release cycle
+- [x] general api stabilisation
+- [x] document usage
+- [x] make async variant
 
-The examples match the folder name in each directory in examples
+## Architecture
 
-## Install
+- `.` Root project mainly used for generating the CLI, which in turn is used to
-
+  bootstrap the code generation from `dagger`
-Simply install like:
+- `crates/dagger-core` Contains all base types used during actual usage. This is
-
+  where the primary logic lives in which the user interacts (\*disclaimer: most
-```bash
+  stuff haven't moved in here yet.)
-cargo add dagger-sdk
+- `crates/dagger-sdk` Contains the actual sdk in which the user interacts,
-```
+  `dagger-core` is reexported through this API as well.
-
+- `crates/dagger-codegen` This is the bulk of the work, it takes the input
-### Usage
+  graphql and spits out the API in which the user interacts, this is heavily
-
+  inspired by other `dagger-sdk's`. It primarily turns graphql into rust code.
-```rust
-#[tokio::main]
-async fn main() -> eyre::Result<()> {
-    let client = dagger_sdk::connect().await?;
-
-    let version = client
-        .container()
-        .from("golang:1.19")
-        .with_exec(vec!["go", "version"])
-        .stdout()
-        .await?;
-
-    println!("Hello from Dagger and {}", version.trim());
-
-    Ok(())
-}
-```
-
-And run it like a normal application:
-
-```bash
-cargo run
-```
-
-### Contributing
-
-See [CONTRIBUTING](./CONTRIBUTING.md)
-
-or just cargo make codegen

ci/Cargo.toml

@@ -8,6 +8,6 @@ edition = "2021"
 [dependencies]
 clap = "4.1.6"
 color-eyre = "0.6.2"
-dagger-sdk = { path = "../crates/dagger-sdk/", version = "^0.2.18" }
+dagger-sdk = { path = "../crates/dagger-sdk/", version = "^0.2.15" }
 eyre = "0.6.8"
 tokio = { version = "1.25.0", features = ["full"] }

ci/src/main.rs

@@ -55,7 +55,6 @@ async fn run_codegen(client: Arc<Query>, _subm: &ArgMatches) -> eyre::Result<()>
         ])
         .with_exec(vec!["cargo", "fmt", "--all"])
         .with_exec(vec!["cargo", "fix", "--workspace", "--allow-dirty"])
-        .with_exec(vec!["cargo", "fmt", "--all"])
         .with_exec(vec!["mv", "crates/dagger-sdk/gen.rs", "/mnt/output/gen.rs"]);
 
     let _ = generated_image.exit_code().await?;

crates/dagger-codegen/Cargo.toml

@@ -11,7 +11,7 @@ publish = true
 
 [dependencies]
 convert_case = "0.6.0"
-dagger-core = { path = "../dagger-core", version = "^0.2.8" }
+dagger-core = { path = "../dagger-core", version = "^0.2.7" }
 
 eyre = "0.6.8"
 genco = "0.17.3"

crates/dagger-codegen/src/functions.rs

@@ -196,22 +196,6 @@ pub fn type_ref_is_scalar(type_ref: &TypeRef) -> bool {
         .unwrap_or(false)
 }
 
-pub fn type_ref_is_enum(type_ref: &TypeRef) -> bool {
-    let mut type_ref = type_ref.clone();
-    if type_ref
-        .kind
-        .pipe(|k| *k == __TypeKind::NON_NULL)
-        .unwrap_or(false)
-    {
-        type_ref = *type_ref.of_type.unwrap().clone();
-    }
-
-    type_ref
-        .kind
-        .pipe(|k| *k == __TypeKind::ENUM)
-        .unwrap_or(false)
-}
-
 pub fn type_ref_is_object(type_ref: &TypeRef) -> bool {
     let mut type_ref = type_ref.clone();
     if type_ref

crates/dagger-codegen/src/rust/functions.rs

@@ -5,8 +5,8 @@ use genco::quote;
 use genco::tokens::quoted;
 
 use crate::functions::{
-    type_field_has_optional, type_ref_is_enum, type_ref_is_list, type_ref_is_list_of_objects,
+    type_field_has_optional, type_ref_is_list, type_ref_is_list_of_objects, type_ref_is_object,
-    type_ref_is_object, type_ref_is_optional, type_ref_is_scalar, CommonFunctions, Scalar,
+    type_ref_is_optional, type_ref_is_scalar, CommonFunctions, Scalar,
 };
 use crate::utility::OptionExt;
 
@@ -133,12 +133,6 @@ fn render_required_args(_funcs: &CommonFunctions, field: &FullTypeFields) -> Opt
                         }
                     }
 
-                    if type_ref_is_enum(&s.input_value.type_) {
-                        return Some(quote! {
-                            query = query.arg_enum($(quoted(name)), $(n));
-                        })
-                    }
-
                     if type_ref_is_list(&s.input_value.type_) {
                         let inner = *s
                             .input_value
@@ -193,14 +187,6 @@ fn render_optional_args(_funcs: &CommonFunctions, field: &FullTypeFields) -> Opt
                     let n = format_struct_name(&s.input_value.name);
                     let name = &s.input_value.name;
 
-                    if type_ref_is_enum(&s.input_value.type_) {
-                        return Some(quote! {
-                            if let Some($(&n)) = opts.$(&n) {
-                                query = query.arg_enum($(quoted(name)), $(n));
-                            }
-                        });
-                    }
-
                     Some(quote! {
                         if let Some($(&n)) = opts.$(&n) {
                             query = query.arg($(quoted(name)), $(&n));

crates/dagger-codegen/src/rust/templates/scalar_tmpl.rs

@@ -11,18 +11,6 @@ pub fn render_scalar(t: &FullType) -> eyre::Result<rust::Tokens> {
 
     Ok(quote! {
         #[derive($serialize, $deserialize, PartialEq, Debug, Clone)]
-        pub struct $(t.name.pipe(|n|format_name(n)))(pub String);
+        pub struct $(t.name.pipe(|n|format_name(n)))(String);
-
-        impl Into<$(t.name.pipe(|n| format_name(n)))> for &str {
-            fn into(self) -> $(t.name.pipe(|n| format_name(n))) {
-                $(t.name.pipe(|n| format_name(n)))(self.to_string())
-            }
-        }
-
-        impl Into<$(t.name.pipe(|n| format_name(n)))> for String {
-            fn into(self) -> $(t.name.pipe(|n| format_name(n))) {
-                $(t.name.pipe(|n| format_name(n)))(self.clone())
-            }
-        }
     })
 }

crates/dagger-core/CHANGELOG.md

@@ -5,42 +5,6 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## v0.2.8 (2023-03-10)
-
-### New Features
-
- - <csr-id-41b20b6268db9d8defe333694e4d3ec019d7c923/> bump version
- - <csr-id-5f9b3a19c0ab6988bc335b020052074f3f101305/> set internal warnings as errors
- - <csr-id-f9e7af931d94fbedacf74f5da9a2f71b1992324b/> introduce tests again
-
-### Bug Fixes
-
- - <csr-id-ecca036bc644fee93fbcb69bf6da9f29169e473e/> fix builder pattern to actually work with default values
-   In previous versions the builder pattern required all values to be set.
-   This has not been fixed, so that default values are allowed.
-
-### Commit Statistics
-
-<csr-read-only-do-not-edit/>
-
- - 4 commits contributed to the release over the course of 13 calendar days.
- - 13 days passed between releases.
- - 4 commits were understood as [conventional](https://www.conventionalcommits.org).
- - 0 issues like '(#ID)' were seen in commit messages
-
-### Commit Details
-
-<csr-read-only-do-not-edit/>
-
-<details><summary>view details</summary>
-
- * **Uncategorized**
-    - bump version ([`41b20b6`](https://github.com/kjuulh/dagger-rs/commit/41b20b6268db9d8defe333694e4d3ec019d7c923))
-    - set internal warnings as errors ([`5f9b3a1`](https://github.com/kjuulh/dagger-rs/commit/5f9b3a19c0ab6988bc335b020052074f3f101305))
-    - introduce tests again ([`f9e7af9`](https://github.com/kjuulh/dagger-rs/commit/f9e7af931d94fbedacf74f5da9a2f71b1992324b))
-    - fix builder pattern to actually work with default values ([`ecca036`](https://github.com/kjuulh/dagger-rs/commit/ecca036bc644fee93fbcb69bf6da9f29169e473e))
-</details>
-
 ## v0.2.7 (2023-02-24)
 
 ### New Features
@@ -51,7 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 <csr-read-only-do-not-edit/>
 
- - 2 commits contributed to the release.
+ - 1 commit contributed to the release.
  - 4 days passed between releases.
  - 1 commit was understood as [conventional](https://www.conventionalcommits.org).
  - 0 issues like '(#ID)' were seen in commit messages
@@ -63,7 +27,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 <details><summary>view details</summary>
 
  * **Uncategorized**
-    - Release dagger-core v0.2.7, dagger-sdk v0.2.15 ([`6a9a560`](https://github.com/kjuulh/dagger-rs/commit/6a9a560cdca097abf23371d44599a2f1b726ae7f))
     - update to dagger-v0.3.13 ([`3e8ca8d`](https://github.com/kjuulh/dagger-rs/commit/3e8ca8d86eafdc1f9d5e8b69f14fb60509549e0f))
 </details>
 

crates/dagger-core/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "dagger-core"
-version = "0.2.8"
+version = "0.2.7"
 edition = "2021"
 readme = "README.md"
 license-file = "LICENSE.MIT"

crates/dagger-sdk/CHANGELOG.md

@@ -6,132 +6,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-## v0.2.18 (2023-03-14)
-
-### New Features
-
- - <csr-id-2c04387c3dd4cfd097a8f142570c58bc756c8ab7/> fix serialization of enum args for graphql
-
-### Commit Statistics
-
-<csr-read-only-do-not-edit/>
-
- - 1 commit contributed to the release.
- - 1 commit was understood as [conventional](https://www.conventionalcommits.org).
- - 0 issues like '(#ID)' were seen in commit messages
-
-### Commit Details
-
-<csr-read-only-do-not-edit/>
-
-<details><summary>view details</summary>
-
- * **Uncategorized**
-    - fix serialization of enum args for graphql ([`2c04387`](https://github.com/kjuulh/dagger-rs/commit/2c04387c3dd4cfd097a8f142570c58bc756c8ab7))
-</details>
-
-## v0.2.17 (2023-03-13)
-
-<csr-id-f67928155f02076cbb41abd4010523879ff3caf1/>
-<csr-id-2cc0231c5f29993081f0f7e15e44cac95a7d6086/>
-<csr-id-9ba01396cb44ee02cf7a16008e3f0bdae9f78754/>
-<csr-id-e9e35edb1cb67eee8cc033212aba3b1888def78f/>
-
-### Bug Fixes
-
- - <csr-id-1bfd084cd28e2b984c61de7f3f9a065cc41be007/> make sure tests have a command to execute
- - <csr-id-5593fce2e16e0aa97a2e6843f15d3bb1121048f5/> remove unused imports
- - <csr-id-c025d1742482d701946c292dcf104421d3cade8e/> add support for String as well
- - <csr-id-d7317e5cf34ee84a7b092357f5fbb15cd2bae2e3/> add public tuple field and into func
- - <csr-id-44fa0240f8197f49fdf942b5c3d89079b59195d1/> update rust crate futures to 0.3.27
-
-### Other
-
- - <csr-id-f67928155f02076cbb41abd4010523879ff3caf1/> initial issue
-
-### Refactor
-
- - <csr-id-2cc0231c5f29993081f0f7e15e44cac95a7d6086/> remove export and instead use exitcode
- - <csr-id-9ba01396cb44ee02cf7a16008e3f0bdae9f78754/> move issues to actual tests and refactor
- - <csr-id-e9e35edb1cb67eee8cc033212aba3b1888def78f/> move issues to another folder
-
-### Commit Statistics
-
-<csr-read-only-do-not-edit/>
-
- - 10 commits contributed to the release over the course of 2 calendar days.
- - 2 days passed between releases.
- - 9 commits were understood as [conventional](https://www.conventionalcommits.org).
- - 0 issues like '(#ID)' were seen in commit messages
-
-### Commit Details
-
-<csr-read-only-do-not-edit/>
-
-<details><summary>view details</summary>
-
- * **Uncategorized**
-    - Release dagger-sdk v0.2.17 ([`a8e6dde`](https://github.com/kjuulh/dagger-rs/commit/a8e6dde615029d9a94d159ed84b5373121cd201f))
-    - make sure tests have a command to execute ([`1bfd084`](https://github.com/kjuulh/dagger-rs/commit/1bfd084cd28e2b984c61de7f3f9a065cc41be007))
-    - remove unused imports ([`5593fce`](https://github.com/kjuulh/dagger-rs/commit/5593fce2e16e0aa97a2e6843f15d3bb1121048f5))
-    - remove export and instead use exitcode ([`2cc0231`](https://github.com/kjuulh/dagger-rs/commit/2cc0231c5f29993081f0f7e15e44cac95a7d6086))
-    - move issues to actual tests and refactor ([`9ba0139`](https://github.com/kjuulh/dagger-rs/commit/9ba01396cb44ee02cf7a16008e3f0bdae9f78754))
-    - add support for String as well ([`c025d17`](https://github.com/kjuulh/dagger-rs/commit/c025d1742482d701946c292dcf104421d3cade8e))
-    - move issues to another folder ([`e9e35ed`](https://github.com/kjuulh/dagger-rs/commit/e9e35edb1cb67eee8cc033212aba3b1888def78f))
-    - add public tuple field and into func ([`d7317e5`](https://github.com/kjuulh/dagger-rs/commit/d7317e5cf34ee84a7b092357f5fbb15cd2bae2e3))
-    - initial issue ([`f679281`](https://github.com/kjuulh/dagger-rs/commit/f67928155f02076cbb41abd4010523879ff3caf1))
-    - update rust crate futures to 0.3.27 ([`44fa024`](https://github.com/kjuulh/dagger-rs/commit/44fa0240f8197f49fdf942b5c3d89079b59195d1))
-</details>
-
-## v0.2.16 (2023-03-10)
-
-<csr-id-e642778d9028726dfb07217814e15ad1dd3b83f2/>
-
-### Chore
-
- - <csr-id-e642778d9028726dfb07217814e15ad1dd3b83f2/> fix tasks
-
-### Documentation
-
- - <csr-id-13b7805e7e6fcf47e0a1318adcc25b4ab773a3c9/> fix missing await in connect
-
-### New Features
-
- - <csr-id-7133bfae9508bc5977548e373c49342a1248d6e4/> with dagger-engine v.0.4.0
- - <csr-id-4381af029521c2cbac9325278d261db79a994657/> add tests to sdk
- - <csr-id-5f9b3a19c0ab6988bc335b020052074f3f101305/> set internal warnings as errors
-
-### Bug Fixes
-
- - <csr-id-ecca036bc644fee93fbcb69bf6da9f29169e473e/> fix builder pattern to actually work with default values
-   In previous versions the builder pattern required all values to be set.
-   This has not been fixed, so that default values are allowed.
-
-### Commit Statistics
-
-<csr-read-only-do-not-edit/>
-
- - 7 commits contributed to the release over the course of 13 calendar days.
- - 13 days passed between releases.
- - 6 commits were understood as [conventional](https://www.conventionalcommits.org).
- - 0 issues like '(#ID)' were seen in commit messages
-
-### Commit Details
-
-<csr-read-only-do-not-edit/>
-
-<details><summary>view details</summary>
-
- * **Uncategorized**
-    - Release dagger-core v0.2.8, dagger-sdk v0.2.16 ([`f390eac`](https://github.com/kjuulh/dagger-rs/commit/f390eac29f1d041d18d2207a5aa0a8d993aab68c))
-    - fix tasks ([`e642778`](https://github.com/kjuulh/dagger-rs/commit/e642778d9028726dfb07217814e15ad1dd3b83f2))
-    - with dagger-engine v.0.4.0 ([`7133bfa`](https://github.com/kjuulh/dagger-rs/commit/7133bfae9508bc5977548e373c49342a1248d6e4))
-    - fix missing await in connect ([`13b7805`](https://github.com/kjuulh/dagger-rs/commit/13b7805e7e6fcf47e0a1318adcc25b4ab773a3c9))
-    - add tests to sdk ([`4381af0`](https://github.com/kjuulh/dagger-rs/commit/4381af029521c2cbac9325278d261db79a994657))
-    - set internal warnings as errors ([`5f9b3a1`](https://github.com/kjuulh/dagger-rs/commit/5f9b3a19c0ab6988bc335b020052074f3f101305))
-    - fix builder pattern to actually work with default values ([`ecca036`](https://github.com/kjuulh/dagger-rs/commit/ecca036bc644fee93fbcb69bf6da9f29169e473e))
-</details>
-
 ## v0.2.15 (2023-02-24)
 
 ### New Features
@@ -146,7 +20,7 @@ and this project adheres to
 
 <csr-read-only-do-not-edit/>
 
- - 3 commits contributed to the release.
+ - 2 commits contributed to the release.
  - 2 days passed between releases.
  - 2 commits were understood as [conventional](https://www.conventionalcommits.org).
  - 0 issues like '(#ID)' were seen in commit messages
@@ -158,7 +32,6 @@ and this project adheres to
 <details><summary>view details</summary>
 
  * **Uncategorized**
-    - Release dagger-core v0.2.7, dagger-sdk v0.2.15 ([`6a9a560`](https://github.com/kjuulh/dagger-rs/commit/6a9a560cdca097abf23371d44599a2f1b726ae7f))
     - set deserialize on enums as well ([`e578b0e`](https://github.com/kjuulh/dagger-rs/commit/e578b0e371e13bc30ada793b7cd6ebe75ba83a07))
     - update to dagger-v0.3.13 ([`3e8ca8d`](https://github.com/kjuulh/dagger-rs/commit/3e8ca8d86eafdc1f9d5e8b69f14fb60509549e0f))
 </details>

crates/dagger-sdk/Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "dagger-sdk"
-version = "0.2.18"
+version = "0.2.15"
 edition = "2021"
 readme = "README.md"
 license-file = "LICENSE.MIT"
@@ -11,14 +11,14 @@ publish = true
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-dagger-core = { path = "../dagger-core", version = "^0.2.8" }
+dagger-core = { path = "../dagger-core", version = "^0.2.7" }
 
 base64 = "0.21.0"
 eyre = "0.6.8"
-futures = "0.3.27"
+futures = "0.3.26"
 gql_client = "1.0.7"
 serde = { version = "1.0.152", features = ["derive"] }
-serde_json = { version = "1.0.93", features = ["raw_value"] }
+serde_json = "1.0.93"
 tokio = { version = "1.25.0", features = ["full"] }
 derive_builder = "0.12.0"
 

crates/dagger-sdk/src/gen.rs

@@ -7,103 +7,19 @@ use std::sync::Arc;
 use tokio::process::Child;
 
 #[derive(Serialize, Deserialize, PartialEq, Debug, Clone)]
-pub struct CacheId(pub String);
+pub struct CacheId(String);
-
-impl Into<CacheId> for &str {
-    fn into(self) -> CacheId {
-        CacheId(self.to_string())
-    }
-}
-
-impl Into<CacheId> for String {
-    fn into(self) -> CacheId {
-        CacheId(self.clone())
-    }
-}
 #[derive(Serialize, Deserialize, PartialEq, Debug, Clone)]
-pub struct ContainerId(pub String);
+pub struct ContainerId(String);
-
-impl Into<ContainerId> for &str {
-    fn into(self) -> ContainerId {
-        ContainerId(self.to_string())
-    }
-}
-
-impl Into<ContainerId> for String {
-    fn into(self) -> ContainerId {
-        ContainerId(self.clone())
-    }
-}
 #[derive(Serialize, Deserialize, PartialEq, Debug, Clone)]
-pub struct DirectoryId(pub String);
+pub struct DirectoryId(String);
-
-impl Into<DirectoryId> for &str {
-    fn into(self) -> DirectoryId {
-        DirectoryId(self.to_string())
-    }
-}
-
-impl Into<DirectoryId> for String {
-    fn into(self) -> DirectoryId {
-        DirectoryId(self.clone())
-    }
-}
 #[derive(Serialize, Deserialize, PartialEq, Debug, Clone)]
-pub struct FileId(pub String);
+pub struct FileId(String);
-
-impl Into<FileId> for &str {
-    fn into(self) -> FileId {
-        FileId(self.to_string())
-    }
-}
-
-impl Into<FileId> for String {
-    fn into(self) -> FileId {
-        FileId(self.clone())
-    }
-}
 #[derive(Serialize, Deserialize, PartialEq, Debug, Clone)]
-pub struct Platform(pub String);
+pub struct Platform(String);
-
-impl Into<Platform> for &str {
-    fn into(self) -> Platform {
-        Platform(self.to_string())
-    }
-}
-
-impl Into<Platform> for String {
-    fn into(self) -> Platform {
-        Platform(self.clone())
-    }
-}
 #[derive(Serialize, Deserialize, PartialEq, Debug, Clone)]
-pub struct SecretId(pub String);
+pub struct SecretId(String);
-
-impl Into<SecretId> for &str {
-    fn into(self) -> SecretId {
-        SecretId(self.to_string())
-    }
-}
-
-impl Into<SecretId> for String {
-    fn into(self) -> SecretId {
-        SecretId(self.clone())
-    }
-}
 #[derive(Serialize, Deserialize, PartialEq, Debug, Clone)]
-pub struct SocketId(pub String);
+pub struct SocketId(String);
-
-impl Into<SocketId> for &str {
-    fn into(self) -> SocketId {
-        SocketId(self.to_string())
-    }
-}
-
-impl Into<SocketId> for String {
-    fn into(self) -> SocketId {
-        SocketId(self.clone())
-    }
-}
 #[derive(Serialize, Deserialize, Debug, PartialEq, Clone)]
 pub struct BuildArg {
     pub name: String,
@@ -955,7 +871,7 @@ impl Container {
 
         query = query.arg("port", port);
         if let Some(protocol) = opts.protocol {
-            query = query.arg_enum("protocol", protocol);
+            query = query.arg("protocol", protocol);
         }
         if let Some(description) = opts.description {
             query = query.arg("description", description);
@@ -1085,7 +1001,7 @@ impl Container {
             query = query.arg("source", source);
         }
         if let Some(sharing) = opts.sharing {
-            query = query.arg_enum("sharing", sharing);
+            query = query.arg("sharing", sharing);
         }
 
         return Container {
@@ -1395,7 +1311,7 @@ impl Container {
 
         query = query.arg("port", port);
         if let Some(protocol) = opts.protocol {
-            query = query.arg_enum("protocol", protocol);
+            query = query.arg("protocol", protocol);
         }
 
         return Container {

crates/dagger-sdk/src/querybuilder.rs

@@ -68,32 +68,6 @@ impl Selection {
         s
     }
 
-    pub fn arg_enum<S>(&self, name: &str, value: S) -> Selection
-    where
-        S: Serialize,
-    {
-        let mut s = self.clone();
-
-        let val = serde_json::to_string(&value).unwrap();
-        let val = val[1..val.len() - 1].to_string();
-
-        println!("test");
-        println!("{}", val);
-
-        match s.args.as_mut() {
-            Some(args) => {
-                let _ = args.insert(name.to_string(), val);
-            }
-            None => {
-                let mut hm = HashMap::new();
-                let _ = hm.insert(name.to_string(), val);
-                s.args = Some(hm);
-            }
-        }
-
-        s
-    }
-
     pub fn build(&self) -> eyre::Result<String> {
         let mut fields = vec!["query".to_string()];
 
@@ -102,7 +76,7 @@ impl Selection {
                 if let Some(args) = sel.args {
                     let actualargs = args
                         .iter()
-                        .map(|(name, arg)| format!("{name}:{}", arg.as_str()))
+                        .map(|(name, arg)| format!("{name}:{arg}"))
                         .collect::<Vec<_>>();
 
                     query = query.add(&format!("({})", actualargs.join(", ")));
@@ -125,9 +99,6 @@ impl Selection {
     {
         let query = self.build()?;
 
-        let qbs = query.as_str();
-        println!("{}", qbs);
-
         let resp: Option<serde_json::Value> = match gql_client.query(&query).await {
             Ok(r) => r,
             Err(e) => eyre::bail!(e),

crates/dagger-sdk/tests/issues/iss_30.rs

@@ -1,47 +0,0 @@
-use dagger_sdk::{QueryContainerOpts, QueryContainerOptsBuilder};
-
-static PLATFORMS: [&str; 2] = ["linux/arm64", "linux/x86_64"];
-
-#[tokio::test]
-async fn test_issue_30_alt() -> eyre::Result<()> {
-    let client = dagger_sdk::connect().await?;
-
-    for platform in PLATFORMS {
-        let ref_ = client
-            .container_opts(QueryContainerOpts {
-                id: None,
-                platform: Some(platform.to_string().into()),
-            })
-            .from("alpine")
-            .with_exec(vec!["echo", "'hello'"])
-            .exit_code()
-            .await?;
-
-        println!("published image to: {:#?}", ref_);
-    }
-
-    Ok(())
-}
-
-#[tokio::test]
-async fn test_issue_30() -> eyre::Result<()> {
-    let client = dagger_sdk::connect().await?;
-
-    for platform in PLATFORMS {
-        let ref_ = client
-            .container_opts(
-                QueryContainerOptsBuilder::default()
-                    .platform(platform)
-                    .build()
-                    .unwrap(),
-            )
-            .from("alpine")
-            .with_exec(vec!["echo", "'hello'"])
-            .exit_code()
-            .await?;
-
-        println!("published image to: {:#?}", ref_);
-    }
-
-    Ok(())
-}

crates/dagger-sdk/tests/issues/iss_33.rs

@@ -1,29 +0,0 @@
-use dagger_sdk::{ContainerWithExposedPortOpts, NetworkProtocol};
-
-#[tokio::test]
-async fn test_issue_30_alt() -> eyre::Result<()> {
-    let client = dagger_sdk::connect().await?;
-
-    client
-        .container()
-        .from("denoland/deno:debian-1.30.3")
-        .with_exposed_port_opts(
-            53,
-            ContainerWithExposedPortOpts {
-                protocol: Some(NetworkProtocol::TCP),
-                description: None,
-            },
-        )
-        .with_exposed_port_opts(
-            53,
-            ContainerWithExposedPortOpts {
-                protocol: Some(NetworkProtocol::UDP),
-                description: None,
-            },
-        )
-        .with_exec(vec!["echo", "hello"])
-        .exit_code()
-        .await?;
-
-    Ok(())
-}

crates/dagger-sdk/tests/issues/mod.rs

@@ -1,2 +0,0 @@
-mod iss_30;
-mod iss_33;

crates/dagger-sdk/tests/mod.rs

@@ -1,5 +1,3 @@
-mod issues;
-
 use dagger_sdk::{connect, ContainerExecOptsBuilder};
 use pretty_assertions::assert_eq;