kjuulh/dagger-rs
1
0
Fork 0
mirror of https://github.com/kjuulh/dagger-rs.git synced 2025-08-04 22:53:26 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(all): race condition in process

Browse Source
This commit is contained in:
Kasper Juul Hermansen
2023-02-20 11:42:03 +01:00
parent b86710d71e
commit a13a2a9ecb
4 changed files with 68 additions and 66 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/dagger-core/src/engine.rs
View File

@@ -11,7 +11,7 @@ impl Engine {
Self {}
}
async fn from_cli(&self, cfg: &Config) -> eyre::Result<(ConnectParams, Child)> {
async fn from_cli(&self, cfg: &Config) -> eyre::Result<(ConnectParams, tokio::process::Child)> {
let cli = Downloader::new("0.3.12".into())?.get_cli().await?;
let cli_session = CliSession::new();
@@ -19,7 +19,7 @@ impl Engine {
Ok(cli_session.connect(cfg, &cli).await?)
}
pub async fn start(&self, cfg: &Config) -> eyre::Result<(ConnectParams, Child)> {
pub async fn start(&self, cfg: &Config) -> eyre::Result<(ConnectParams, tokio::process::Child)> {
// TODO: Add from existing session as well
self.from_cli(cfg).await
}